Skip to content

Fix wrong handling of named parameters #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ofer1992 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix wrong handling of named parameters #13

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1d6e72
Fix wrong handling of named parameters
ofer1992 Sep 5, 2024
7899a94
fix in query(), convert to tuple if not dict
ofer1992 Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions sqlite_minutils/db.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ def query(
:param params: Parameters to use in that query - an iterable for ``where id = ?``
parameters, or a dictionary for ``where id = :id``
"""
cursor = self.execute(sql, tuple(params or tuple()))
cursor = self.execute(sql, params or tuple())
keys = [d[0] for d in cursor.description]
for row in cursor:
yield dict(zip(keys, row))
Expand All @@ -431,7 +431,9 @@ def execute(
if self._tracer:
self._tracer(sql, parameters)
if parameters is not None:
return self.conn.execute(sql, tuple(parameters))
if not isinstance(parameters, dict):
parameters = tuple(parameters)
return self.conn.execute(sql, parameters)
else:
return self.conn.execute(sql)

Expand Down