DS9 for python3 #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi, Please detail the following:
Thank you! |
Author
|
I fixed loading array from PyGuide to DS9 - using DS9.showArray function. Numpy function array.tofile is slightly different in py3 compare to py2. Changes are mostly caused by encoding and string representation (as bytes in py3). So, it's better to use file.write(array.tobytes()) instead of it. And on other 2 places there were also some problems with encoding. Generally, the fix is in usage DS9.showArray in python 3. |
Contributor
|
@pavolgaj , sorry, been tied up here and I still haven't gotten around to testing this out. I plan to soon. Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just made some modifications to the DS9.py file to work under python3 with PyGuide - show the image in SAO DS9.