Proposed fix #319 - non-portable uname -i use#320
Open
krayon wants to merge 3 commits intoAppImageCommunity:masterfrom
Open
Proposed fix #319 - non-portable uname -i use#320krayon wants to merge 3 commits intoAppImageCommunity:masterfrom
uname -i use#320krayon wants to merge 3 commits intoAppImageCommunity:masterfrom
Conversation
Member
|
Pending until someone has an issue that this fixes. (I never touch code that works for me to "hypothetically" improve something, because from there it can only get worse, right?) |
*UNTESTED*
Member
|
Thanks @krayon. I will consider to merge this patch if someone eperiences an actual real-world issue (as opposed to theory) that this solves. |
Author
|
@probonopd If you are going to wait for the next time there's an issue anyway, I'd advise using the original, greatly superior implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UNTESTED (I don't actually use AppImage)