Fix for last block is not multiple of blocksize#84
Open
dh-apporto wants to merge 1 commit intoAppImageCommunity:masterfrom
Open
Fix for last block is not multiple of blocksize#84dh-apporto wants to merge 1 commit intoAppImageCommunity:masterfrom
dh-apporto wants to merge 1 commit intoAppImageCommunity:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: .zsync truncates if source file is not a multiple of block size
This PR fixes an issue where zsyncmake2 would truncate the .zsync "Length" and omit the last partial block if the source file was not an exact multiple of the block size.
Caveats
I have not worked with C++ for many years. This code fix was generated by AI in github copilot claude sonnet 4 when I described the problem I was encountering. One thing to note, even though the file is now being copied across completely (verified with md5sum on source and destination file), the
usedcount is not accurate in the output: