Conversation
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
amilcarlucas
force-pushed
the
RPM_Telemetry
branch
from
5e5df5a to
66a6db1
Compare
Contributor
Test Results 2 files 2 suites 1m 28s ⏱️ Results for commit aa529f6. ♻️ This comment has been updated with latest results. |
amilcarlucas
force-pushed
the
RPM_Telemetry
branch
from
66a6db1 to
aa529f6
Compare
Contributor
There was a problem hiding this comment.
PR Overview
This PR introduces initial RPM telemetry support to the ESC components in the telemetry configuration. Key changes include:
- Adding a new localization string for "RPM Telemetry" in the UI.
- Updating JSON data to support new "RPM Telemetry" fields for ESC.
- Modifying the ESC protocol combobox entries to incorporate RPM telemetry connection and protocol options.
Reviewed Changes
| File | Description |
|---|---|
| ardupilot_methodic_configurator/frontend_tkinter_component_editor.py | Added RPM telemetry string, JSON update block, and updated combobox logic for RPM telemetry |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (3)
ardupilot_methodic_configurator/frontend_tkinter_component_editor.py:261
- [nitpick] The variable '_vehicle_components_strings' is overwritten multiple times with different values; if its purpose is solely to register strings for localization, consider adding a comment or using distinct variables for clarity.
_vehicle_components_strings = _("RPM Telemetry")
ardupilot_methodic_configurator/frontend_tkinter_component_editor.py:309
- The block updating the 'ESC' RPM Telemetry fields appears to duplicate similar logic that may already exist in the codebase; verify if this duplication is intentional or if it should be consolidated to avoid redundant processing.
# To update old JSON files that do not have these new
ardupilot_methodic_configurator/frontend_tkinter_component_editor.py:514
- [nitpick] Similar assignments to 'rpm_connections' occur in multiple branches; consider refactoring this repetitive logic into a helper function to improve maintainability.
rpm_connections = ["None", "I/O Only", *serial_ports, *can_ports]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will later be used to make parameter value decisions