-
Notifications
You must be signed in to change notification settings - Fork 4
Custom 404 and 500 error pages #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Timilehin08
wants to merge
9
commits into
AritDevCircle:main
Choose a base branch
from
Timilehin08:timiwork-on-errorpages
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Custom 404 and 500 error pages #116
Timilehin08
wants to merge
9
commits into
AritDevCircle:main
from
Timilehin08:timiwork-on-errorpages
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
4 tasks
This was
linked to
issues
May 23, 2021
4 tasks
Contributor
Author
|
Hello everyone! I had to create another branch and this PR because resolving the conflict on the other branch/PR was becoming way too problematic than it should be. |
GabrielleEaston
approved these changes
May 25, 2021
Contributor
GabrielleEaston
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected in the local environment! Thanks, @Timilehin08. Great styling 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
[] Feature
[] Refactor
[] Bug Fix
Optimization
[] Documentation Update
Other (describe: Styling )
Description of what PR does
rails g controller errors not_found internal_server_error.config/routes.rb.application.rbfile.config/environments/development.rbin order to test things out locally.app/views/errorsaccordingly.Related PRs and/or Issues (if any)
QA Instructions, Screenshots, Recordings
For example, go to http://127.0.0.1:3000/sss to see how error page looks like.
https://web-crunch.com/posts/custom-error-page-ruby-on-rails
Added tests?
Added to documentation?