Skip to content

Conversation

@Timilehin08
Copy link
Contributor

What type of PR is this? (check all applicable)

  • [] Feature

  • [] Refactor

  • [] Bug Fix

  • Optimization

  • [] Documentation Update

  • Other (describe: Styling )

Description of what PR does

  • Removes 404 and 500 html file in Public folder and Generates a new ErrorsController that inherits from ApplicationController with command rails g controller errors not_found internal_server_error.
  • Configures Routes to Handle New Errors Page in config/routes.rb.
  • Adjusts configuration to turn off the default way Rails will handle errors in the main application.rb file.
  • Disables configuration in config/environments/development.rb in order to test things out locally.
  • Styles, edits and adjusts the views within app/views/errors accordingly.

Related PRs and/or Issues (if any)

QA Instructions, Screenshots, Recordings

For example, go to http://127.0.0.1:3000/sss to see how error page looks like.
https://web-crunch.com/posts/custom-error-page-ruby-on-rails

Added tests?

  • yes
  • no, because they aren't needed (please include reasons for why tests aren't needed)
  • no, because I need help
  • no, they will be added later (please create an Issue for it)

Added to documentation?

  • Yes, project README
  • No documentation needed

@Timilehin08
Copy link
Contributor Author

Hello everyone! I had to create another branch and this PR because resolving the conflict on the other branch/PR was becoming way too problematic than it should be.

@Timilehin08 Timilehin08 added the Ready For QA Work done; ready to be reviewed label May 23, 2021
@Timilehin08 Timilehin08 mentioned this pull request May 23, 2021
8 tasks
Copy link
Contributor

@GabrielleEaston GabrielleEaston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected in the local environment! Thanks, @Timilehin08. Great styling 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready For QA Work done; ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

404 and 500 error pages 404-redirect for misspelled URLs and Indexed we haven't implemented

2 participants