Skip to content

keep minimum strip count #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cfinck27 wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

keep minimum strip count #154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion _generator/bin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ const defaultScrapers = [
]
const expirationDays = 90
const expirationCount = 50
const minimumCount = 10

function migration([ id, seriesObject ]) {
// seriesObject.strips = seriesObject.strips.filter(s => s.date !== null && s.date.slice(7) !== '2020-09') // bye bye all this month
Expand Down Expand Up @@ -128,7 +129,7 @@ async function runScraper(scraperName) {
const verifiedSeriesObjects = objMapValue(newSeriesObjects, newSeriesObject => {
const strips = newSeriesObject.strips
.map(({ url, date, imageUrl }) => ({ url, date, imageUrl }))
.filter((strip, i) => (i === 0 || new Date(strip.date) > expirationDate)) // keeps recent strips
.filter((strip, i) => ((i >= 0 && i < minimumCount) || new Date(strip.date) > expirationDate)) // keeps recent strips
.slice(0, expirationCount)
return strips ? { ...newSeriesObject, strips } : null
})
Expand Down