Skip to content

Conversation

@Soulter
Copy link
Member

@Soulter Soulter commented Oct 4, 2025

fixes #2953


Motivation / 动机

修复 #2953

Modifications / 改动点

Verification Steps / 验证步骤

Screenshots or Test Results / 运行截图或测试结果

Compatibility & Breaking Changes / 兼容性与破坏性变更

  • 这是一个破坏性变更 (Breaking Change)。/ This is a breaking change.
  • 这不是一个破坏性变更。/ This is NOT a breaking change.

Checklist / 检查清单

  • 😊 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。/ If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
  • 👀 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”。/ My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
  • 🤓 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到了 requirements.txtpyproject.toml 文件相应位置。/ I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in requirements.txt and pyproject.toml.
  • 😮 我的更改没有引入恶意代码。/ My changes do not introduce malicious code.

Sourcery 总结

将 LongTermMemory 实例传入 ConversationCommands,以便 reset 能够正确清除群聊上下文数据。

Bug 修复:

  • 通过将 LongTermMemory 传入 ConversationCommands,确保 reset 清除群聊上下文。

增强功能:

  • 为 ConversationCommands.init 中的 ltm 参数添加类型注解。
Original summary in English

Summary by Sourcery

Pass the LongTermMemory instance into ConversationCommands so that reset can properly clear group chat context data.

Bug Fixes:

  • Ensure reset clears group chat context by passing LongTermMemory to ConversationCommands.

Enhancements:

  • Add type annotation for the ltm parameter in ConversationCommands.init.

@auto-assign auto-assign bot requested review from Larch-C and advent259141 October 4, 2025 16:04
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你好 - 我已经审阅了你的修改,它们看起来很棒!


Sourcery 对开源项目免费 - 如果你喜欢我们的评审,请考虑分享它们 ✨
帮助我变得更有用!请在每条评论上点击 👍 或 👎,我将利用这些反馈来改进你的评审。
Original comment in English

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Soulter Soulter merged commit 1dfc831 into master Oct 4, 2025
5 checks passed
@Soulter Soulter deleted the fix/2953 branch October 18, 2025 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] reset 在开启聊天上下文感知之后失效

2 participants