Add support to send JS exceptions to Sentry #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhnstn
force-pushed
the
add/js-exception-logging
branch
from
47fe77b to
57e6f1a
Compare
jhnstn
changed the title
13 tasks
This is needed to make Sentry symbolicate the stack trace.
Member
|
hi folks 👋 Just a heads-up that I recently bumped Sentry SDK to new major version #201 . Maybe we could sync this branch with |
Contributor
Hey @wzieba 👋 , thanks for the heads up 🙇 ! Sure, we'll update with |
fluiddot
reviewed
Mar 7, 2024
...acks/src/main/java/com/automattic/android/tracks/crashlogging/internal/SentryCrashLogging.kt
Show resolved
Hide resolved
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Changes:
This PR expands the Crash logging service to support logging JavaScript exceptions to Sentry. This will allow hybrid sources like React Native (used in Gutenberg Mobile) to log exceptions with detailed information and symbolicated stack traces, which will greatly simplify the crash debugging process.
To test
Since it involves testing exceptions, we need to modify the code to force them and generate an installable build. A test PR has been created for this purpose, follow the testing instructions from wordpress-mobile/gutenberg-mobile#6654.