-
Notifications
You must be signed in to change notification settings - Fork 13
Remove support for distribution via CocoaPods #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for distribution via CocoaPods #311
Conversation
Also update SwiftLint configuration and use latest version, 0.63.0
|
Pausing work on this for the moment while I gather input on how to address the failing version consistency check. Problem: We want the version hardcoded in the source and sent as part as the user agent to be in sync with the library's version as used by the package manager. This was straightforward with CocoaPods because it required hardcoding the version in the There are of course possible solutions we could implement for this, like a CI check that runs only on tags, or updating the script to do something like However, taking a step back I wonder whether we can do away with the library version in the user agent in the first place, thus removing the need for the validation step. I asked about this internally, ref p1767675546597369-slack-C03DKP1JP. |
This has been discussed internally and we decided that the overhead of keeping the version in sync between code and Git tags was not worth the value of tracking it in the user agent. Given we already track the version of the app that logs events via the library, the library's version can always be deduced.
No longer necessary following the hardcoded version removal in f7e5901
| ### Internal Changes | ||
|
|
||
| - Constrained version to `< 8.49.0` for CocoaPods installations to avoid deprecation warnings till we upgrade Sentry to version 9.x [#310] | ||
| - With this version, Tracks only supports distribution via Swift Package Manager [#311] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seemed redundant to track the #310 workaround given it was CocoaPods related.
twstokes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a quick scan and didn't spot anything. This should be a low-risk change anyway, so approving. 👍
Connecting dots as it looks like this was determined in #313. |
See https://linear.app/a8c/issue/AINFRA-1693
CHANGELOG.mdif necessary.