enhanced ui and improved readability of code by renaming variables and removing not needed comments of Tic-Tac-Toe Game#929
Open
Prasoon52 wants to merge 5 commits intoAyushparikh-code:mainfrom
Open
Conversation
Author
|
hello @Ayushparikh-code please do let me know if any changes are needed |
codeCraft-Ritik
left a comment
codeCraft-Ritik
left a comment
There was a problem hiding this comment.
“Nice approach — the logic flows well and is readable.”
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored the entire JavaScript codebase for the Tic-Tac-Toe game to use modern practices and improve readability. Added a 'Main Menu' button to enhance user experience.
Replaced all inline 'onclick' attributes with '.addEventListener()' for better separation of concerns and code management.
Renamed variables and functions to be self-explanatory
Added a 'Main Menu' button on the results screen
Updated the HTML with accessibility attributes
https://github.com/Ayushparikh-code/Web-dev-mini-projects/issues/
resolves #903
resolves #926
please let me know if any changes are needed