Skip to content

Conversation

@johnathan79717
Copy link
Contributor

Summary

  • Fixes a bug where the ci-barretenberg-full label was being ignored for PRs targeting merge-train/barretenberg
  • The branch-based check for ci-barretenberg was evaluated first, causing the explicit label to be skipped
  • This reorders the conditions so explicit labels take precedence over branch defaults

Context

Discovered on PR #19461 where setting ci-barretenberg-full label resulted in only 13 seconds of CI because the target branch (merge-train/barretenberg) matched ci-barretenberg mode first, causing a cache hit.

…berg

The ci-barretenberg-full label was being ignored for PRs targeting
merge-train/barretenberg because the branch-based check for ci-barretenberg
was evaluated first. This reorders the conditions so explicit labels
take precedence over branch defaults.
@johnathan79717 johnathan79717 requested review from ludamad and removed request for charlielye January 9, 2026 16:14
@johnathan79717 johnathan79717 added this pull request to the merge queue Jan 9, 2026
@johnathan79717 johnathan79717 removed this pull request from the merge queue due to a manual request Jan 9, 2026
@johnathan79717 johnathan79717 added the ci-barretenberg-full Run all barretenberg checks. label Jan 9, 2026
@johnathan79717 johnathan79717 added ci-barretenberg Run all barretenberg/cpp checks. and removed ci-barretenberg-full Run all barretenberg checks. labels Jan 9, 2026
@johnathan79717 johnathan79717 added this pull request to the merge queue Jan 9, 2026
@johnathan79717 johnathan79717 removed this pull request from the merge queue due to a manual request Jan 9, 2026
@johnathan79717 johnathan79717 changed the base branch from next to merge-train/barretenberg January 9, 2026 17:02
@johnathan79717 johnathan79717 changed the base branch from merge-train/barretenberg to next January 9, 2026 17:04
@johnathan79717 johnathan79717 added this pull request to the merge queue Jan 9, 2026
Merged via the queue into next with commit 70257e7 Jan 9, 2026
39 of 41 checks passed
@johnathan79717 johnathan79717 deleted the jh/fix-ci-barretenberg-full-label-order branch January 9, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-barretenberg Run all barretenberg/cpp checks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants