feat: wallet SDK better flow, mitm protection #19477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nventuro
approved these changes
Jan 12, 2026
| sharedKey, | ||
| }); | ||
| } catch { | ||
| // Failed to derive key, skip this wallet |
Contributor
Author
There was a problem hiding this comment.
console.log is forbidden by the linter and I'm reluctant to add an opinionated logger here (we have a lot of that as it is...)
Comment on lines
+290
to
+293
| const EMOJI_ALPHABET = [ | ||
| '🔵', | ||
| '🟢', | ||
| '🔴', |
| # Wallet SDK Integration Guide for Third-Party Wallet Developers | ||
|
|
||
| This guide explains how to integrate your wallet with the Aztec Wallet SDK, enabling dApps to discover and interact with your wallet implementation. | ||
|
|
Improved discovery on the SDK: * Avoid "connect" messages and handle everything on the discovery * Hash the derived shared key and expose it (independently) at the app and extension levels, so the user can visually inspect they're connected to the expected wallet Co-authored-by: thunkar <gregojquiros@gmail.com>
AztecBot
force-pushed
the
gj/extension_wallet_simplification_verification
branch
from
1d85840 to
49a5954
Compare
Collaborator
Flakey Tests🤖 says: This CI run detected 2 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 13, 2026
Improved discovery on the SDK: * Avoid "connect" messages and handle everything on the discovery * Hash the derived shared key and expose it (independently) at the app and extension levels, so the user can visually inspect they're connected to the expected wallet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved discovery on the SDK: