-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[Microsoft.App] Update the error shown on ConsumptionOnly env creation #9527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…nt on an existing WP env
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @jepetty, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
Hi @jepetty Release SuggestionsModule: containerapp
Notes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR improves the error message shown when users attempt to create a Consumption-Only environment with a name that's already in use by an existing WorkloadProfiles environment. The previous error message was confusing ("At least 1 workload profile must be specified"), but the new message clearly states that the existing environment uses workload profiles and suggests creating a new environment.
Changes:
- Refactored the
set_up_workload_profilesmethod to check for existing environment before branching on theenable_workload_profilesflag - Added a new validation in the
elsebranch to raise a clearer error when attempting to create a Consumption-Only environment with a name that's already used by a WorkloadProfiles environment
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
The CI might be failed due to the |
This is a small change to make the error message clearer for users when they try to create a ConsumptionOnly environment but an existing WorkloadProfiles environment with the same name already exists. The previous error was "At least 1 workload profile must be specified" - very confusing
Related command
az containerapp env create --name --resource-group --enable-workload-profiles false
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)