{Containerapp} Update recording files to fix credential #32539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Greedygre
requested review from
Juliehzl,
howang-ms,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
JennyLawrance,
chinadragon0515,
ebencarek,
jijohn14,
jsntcy,
pagariyaalok,
ruslany,
sanchitmehta,
torosent,
vinisoto,
vturecek,
wangzelin007 and
yonzhan
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates test recording files to properly sanitize credentials by replacing actual customer IDs and shared keys with fake values. The changes ensure that sensitive information is not exposed in test recordings.
- Replaces real
customerIdvalues with"veryFakedCustomerId==" - Replaces real
sharedKeyvalues with"abc123" - Adds consistent spacing in some JSON response bodies
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 19 comments.
Show a summary per file
| File | Description |
|---|---|
| test_containerappjob_eventtriggered_create_with_yaml.yaml | Sanitizes Log Analytics credentials in request body |
| test_containerappjob_create_with_yaml.yaml | Sanitizes Log Analytics credentials in request body |
| test_containerappjob_create_with_environment_id.yaml | Sanitizes Log Analytics credentials in multiple request bodies |
| test_containerapp_up_source_with_dockerfile_e2e.yaml | Sanitizes credentials in both response and request bodies, adds JSON spacing |
| test_containerapp_up_source_with_buildpack_e2e.yaml | Sanitizes credentials in both response and request bodies, adds JSON spacing |
| test_containerapp_up_image_e2e.yaml | Sanitizes credentials in both response and request bodies, adds JSON spacing |
| test_containerapp_tcp_ingress.yaml | Sanitizes Log Analytics credentials in request body |
| test_containerapp_get_customdomainverificationid_e2e.yaml | Sanitizes credentials in both response and request bodies |
| test_containerapp_env_update_custom_domains.yaml | Sanitizes Log Analytics credentials in request body |
| test_containerapp_env_storage.yaml | Sanitizes Log Analytics credentials in request body |
| test_containerapp_env_p2p_traffic_encryption.yaml | Sanitizes Log Analytics credentials in request body |
| test_containerapp_env_mtls.yaml | Sanitizes Log Analytics credentials in request body |
| test_containerapp_env_internal_only_e2e.yaml | Sanitizes Log Analytics credentials in request body |
| test_containerapp_env_custom_domains.yaml | Sanitizes Log Analytics credentials in multiple request bodies |
| test_containerapp_env_certificate_e2e.yaml | Sanitizes Log Analytics credentials in request body |
| test_containerapp_custom_domains_e2e.yaml | Sanitizes Log Analytics credentials in request body |
| test_containerapp_create_with_vnet_yaml.yaml | Sanitizes credentials in both response and request bodies, adds JSON spacing |
| test_containerapp_create_with_environment_id.yaml | Sanitizes Log Analytics credentials in multiple request bodies |
| test_containerapp_compose_create_environment_to_target_location.yaml | Sanitizes credentials in both response and request bodies, adds JSON spacing |
| test_container_app_mount_secret_update_e2e.yaml | Sanitizes Log Analytics credentials in request body |
| test_container_app_mount_secret_e2e.yaml | Sanitizes Log Analytics credentials in request body |
| test_container_app_mount_azurefile_e2e.yaml | Sanitizes Log Analytics credentials in request body |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...mmand_modules/containerapp/tests/latest/recordings/test_containerapp_custom_domains_e2e.yaml
Show resolved
Hide resolved
...ntainerapp/tests/latest/recordings/test_containerapp_get_customdomainverificationid_e2e.yaml
Show resolved
Hide resolved
...ure/cli/command_modules/containerapp/tests/latest/recordings/test_containerapp_env_mtls.yaml
Show resolved
Hide resolved
...mmand_modules/containerapp/tests/latest/recordings/test_containerapp_env_custom_domains.yaml
Show resolved
Hide resolved
...mand_modules/containerapp/tests/latest/recordings/test_containerapp_env_certificate_e2e.yaml
Show resolved
Hide resolved
...nd_modules/containerapp/tests/latest/recordings/test_containerapp_env_internal_only_e2e.yaml
Show resolved
Hide resolved
...tests/latest/recordings/test_containerapp_compose_create_environment_to_target_location.yaml
Show resolved
Hide resolved
...les/containerapp/tests/latest/recordings/test_containerapp_up_source_with_buildpack_e2e.yaml
Show resolved
Hide resolved
...odules/containerapp/tests/latest/recordings/test_containerapp_env_update_custom_domains.yaml
Show resolved
Hide resolved
...ommand_modules/containerapp/tests/latest/recordings/test_container_app_mount_secret_e2e.yaml
Show resolved
Hide resolved
yanzhudd
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.