[RDBMS] Remove blocking of HA enablement for servers with SSD v2 storage type #32542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nachoalonsoportillo
requested review from
calvinhzy and
evelyn-ys
as code owners
️✔️AzureCLI-FullTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
️✔️AzureCLI-BreakingChangeTest
|
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables High Availability support for PostgreSQL flexible servers using PremiumV2_LRS (SSD v2) storage by removing validation that previously blocked this combination.
- Removed the
high_availabilityparameter from the_pg_storage_type_validatorfunction and its validation logic - Updated tests to verify that High Availability can now be enabled and disabled on servers with PremiumV2_LRS storage
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/rdbms/validators.py | Removed the high_availability parameter and associated validation check that blocked HA on PremiumV2_LRS storage servers |
| src/azure-cli/azure/cli/command_modules/rdbms/tests/latest/test_rdbms_flexible_commands.py | Changed test expectations from expecting HA enablement to fail on SSD v2 servers to verifying it succeeds, including both enabling and disabling HA |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/azure-cli/azure/cli/command_modules/rdbms/tests/latest/test_rdbms_flexible_commands.py
Outdated
Show resolved
Hide resolved
…t_rdbms_flexible_commands.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
nasc17
approved these changes
Dec 17, 2025
evelyn-ys
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az postgres flexible-server create --storage-type PremiumV2_LRS --high-availability SameZone | ZoneRedundantaz postgres flexible-server update --high-availability SameZone | ZoneRedundant(for servers with storage of type PremiumV2_LRS)Description
Now that High Availability was announced as supported on servers with PremiumV2_LRS storage type we should remove current blocking from CLI.
Testing Guide
History Notes
[RDBMS]
az postgres flexible-server create/update: Enable support for High Availability on servers with PremiumV2_LRS storage typeThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.