[Containerapp] Fix #32594: az containerapp compose create: Fix TypeError when docker-compose file include env_file without environment
#32601
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Greedygre
requested review from
Juliehzl,
howang-ms,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @Greedygre, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
ebencarek,
jsntcy,
ruslany,
sanchitmehta,
wangzelin007 and
yonzhan
This reverts commit 31202c1.
microsoft-github-policy-service
bot
requested review from
JennyLawrance,
chinadragon0515,
jijohn14,
pagariyaalok,
torosent,
vinisoto and
vturecek
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a TypeError in az containerapp compose create command when a docker-compose file includes env_file without environment. The issue stems from a bug in pycomposefile version 0.0.32 that incorrectly assumes the environment field must exist when env_file is present.
Key Changes:
- Upgraded pycomposefile dependency from version 0.0.32 to 0.0.34 across all platform configurations
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/azure-cli/setup.py | Updated minimum version constraint for pycomposefile from >=0.0.32 to >=0.0.34 |
| src/azure-cli/requirements.py3.windows.txt | Updated pinned pycomposefile version from 0.0.32 to 0.0.34 for Windows |
| src/azure-cli/requirements.py3.Linux.txt | Updated pinned pycomposefile version from 0.0.32 to 0.0.34 for Linux |
| src/azure-cli/requirements.py3.Darwin.txt | Updated pinned pycomposefile version from 0.0.32 to 0.0.34 for macOS |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bowen5
approved these changes
Jan 5, 2026
bowen5
approved these changes
Jan 5, 2026
ShichaoQiu
approved these changes
Jan 5, 2026
yanzhudd
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az containerapp compose create
Description
Refer issue: #32594
In pycomposefile version <=
0.0.32, there is a bug it assume whenenv_fileexist, environment should exist.Otherwise it throws error
TypeError: 'NoneType' object is not iterablelike following:code in pycomposefile version <=
0.0.32code in pycomposefile version >=
0.0.33, it fix with change:Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.