Extension Update Warning #6512
Merged
Extension Update Warning #6512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spboyer
approved these changes
Jan 14, 2026
wbreza
requested review from
JeffreyCA,
hemarina,
rajeshkamal5050,
tg-msft and
weikanglim
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds extension update checking functionality that notifies users when newer versions of installed extensions are available. The implementation runs update checks in parallel with extension execution to avoid adding latency.
Changes:
- Adds registry caching system with 4-hour TTL and per-source isolation
- Implements update checker with 24-hour warning cooldown tracked per extension
- Enhances WarningMessage UX component to support hint bullets
- Integrates update checks into extension command execution flow
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| cli/azd/pkg/output/ux/warning.go | Added Hints field to WarningMessage for displaying bulleted suggestions |
| cli/azd/pkg/extensions/extension.go | Added LastUpdateWarning field to track warning cooldown per extension |
| cli/azd/pkg/extensions/registry_cache.go | Implements per-source registry caching with TTL and file-based storage |
| cli/azd/pkg/extensions/registry_cache_test.go | Unit tests for cache manager functionality |
| cli/azd/pkg/extensions/update_checker.go | Core update checking logic with version comparison and cooldown management |
| cli/azd/pkg/extensions/update_checker_test.go | Unit tests for update checker |
| cli/azd/pkg/extensions/update_integration_test.go | Integration tests covering full update check workflow |
| cli/azd/pkg/extensions/manager.go | Added UpdateInstalled method to persist extension metadata changes |
| cli/azd/cmd/extensions.go | Integrated update checking into extension execution with async goroutine |
| cli/azd/.vscode/cspell.yaml | Added spelling exceptions for new terms |
Comments suppressed due to low confidence (4)
cli/azd/pkg/extensions/update_checker.go:92
- The comment uses "cool down" (two words) but elsewhere in the codebase it's written as "cooldown" (one word). Use consistent terminology throughout for better readability and searchability.
// ShouldShowWarning checks if a warning should be shown (respecting cool down)
cli/azd/cmd/extensions.go:172
- The defer function uses a non-blocking select with a default case to check if the update result is ready. If the goroutine hasn't completed by the time the extension finishes, the warning is silently skipped. This means fast-running extensions might never show update warnings even when updates are available. Consider either waiting for a reasonable timeout, or logging when the check didn't complete in time so users/developers are aware of the behavior.
defer func() {
// Collect result and show warning if needed (non-blocking read)
select {
case result := <-updateResultChan:
if result != nil && result.shouldShow && result.warning != nil {
a.console.MessageUxItem(ctx, result.warning)
a.console.Message(ctx, "")
}
default:
// Check didn't complete in time, skip warning
}
}()
cli/azd/pkg/extensions/manager.go:246
- The
UpdateInstalledmethod checks if the extension exists in the map but then overwrites it unconditionally. If the extension doesn't exist, the function returns an error, but if it does exist, the entire extension object is replaced rather than just updating specific fields. This means if the caller modifies the extension object between retrieval and update, unrelated fields could be changed. Consider documenting this full-replacement behavior, or implementing a more granular update mechanism.
// UpdateInstalled updates an installed extension's metadata in the config
func (m *Manager) UpdateInstalled(extension *Extension) error {
extensions, err := m.ListInstalled()
if err != nil {
return fmt.Errorf("failed to list installed extensions: %w", err)
}
if _, exists := extensions[extension.Id]; !exists {
return ErrInstalledExtensionNotFound
}
extensions[extension.Id] = extension
if err := m.userConfig.Set(installedConfigKey, extensions); err != nil {
return fmt.Errorf("failed to set extensions section: %w", err)
}
if err := m.configManager.Save(m.userConfig); err != nil {
return fmt.Errorf("failed to save user config: %w", err)
}
return nil
}
cli/azd/pkg/extensions/update_checker.go:37
- The comment uses "cool downs" (two words) but elsewhere in the codebase and in the constant name it's written as "cooldown" (one word). Use consistent terminology throughout for better readability and searchability.
// UpdateChecker checks for extension updates and manages warning cool downs
cli/azd/cmd/extensions.go
Outdated
| showUpdateWarning := !isJsonOutputFromArgs(os.Args) | ||
| if showUpdateWarning { | ||
| updateResultChan := make(chan *updateCheckOutcome, 1) | ||
| go a.checkForUpdateAsync(ctx, extension, updateResultChan) |
There was a problem hiding this comment.
The context passed to the goroutine originates from the parent Run method. If the parent context is cancelled after the goroutine starts but before update checking completes, operations in checkForUpdateAsync may fail or behave unexpectedly. Consider using context.WithoutCancel or creating a detached context for the background update check to ensure it can complete independently of the main command execution.
Suggested change
| go a.checkForUpdateAsync(ctx, extension, updateResultChan) | |
| go a.checkForUpdateAsync(context.WithoutCancel(ctx), extension, updateResultChan) |
vhvb1989
approved these changes
Jan 15, 2026
JeffreyCA
reviewed
Jan 15, 2026
wbreza
force-pushed
the
ext-update-check
branch
from
5dc0725 to
f3c7e5a
Compare
Collaborator
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
rajeshkamal5050
approved these changes
Jan 16, 2026
JeffreyCA
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension Update Warning
When users run an extension command, azd now checks if a newer version is available and displays a warning after execution with upgrade instructions.
Key Features
~/.azd/cache/extensions/<source>.jsonwith 4hr TTL (configurable viaAZD_EXTENSION_CACHE_TTL)Extension.LastUpdateWarningfield - auto-cleaned on uninstall--output jsonis usedExample Output