[Az.Accounts] Fix ClientRequestId being overwritten in telemetry payload

[DanielMicrosoft]

Description

Fixes #23555

Previously, the value in telemetry for ClientRequestId would be derived from the client side x-ms-client-request-id, however it would be overwritten by the x-ms-request-id coming back from the server side.

This would also set Properties['x-ms-client-request-id'] in telemetry to be that value from the server response x-ms-request-id.

This issue would be inherited by AutoRest generated modules.

This PR will adjust behaviour of setting telemetry values to use the client side x-ms-client-request-id as the ClientRequestId in telemetry, and preserve it in the Properties['x-ms-client-request-id'] value also.

Mandatory Checklist

• Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)

  • General release
  • Public preview
  • Private preview
  • Engineering build
  • No need for a release

• Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

• SHOULD update ChangeLog.md file(s) appropriately
  • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
  • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
• SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
• SHOULD have proper test coverage for changes in pull request.
• SHOULD NOT adjust version of module manually in pull request

[azure-client-tools-bot-prd]

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

[Copilot]

Pull request overview

This PR fixes an issue where the ClientRequestId telemetry value was being incorrectly overwritten by server-side response headers. The fix ensures that once ClientRequestId is set from client-side request headers in OnBeforeCall, it will not be overwritten when OnResponseCreated processes the response headers.

Key changes:

• Added a guard condition in OnResponseCreated to prevent overwriting ClientRequestId if it's already populated
• Preserves the client-side request ID as the source of truth for telemetry

[isra-fel]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

[YanaXu]

@dolauli , could you review this PR? Thanks.