Skip to content

Conversation

@alzimmermsft
Copy link
Member

Description

Small code change PR to remove test dependencies that weren't necessary.

Also updates to Jacoco, Byte Buddy, and ASM dependencies for better Java 25 support.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

API Change Check

APIView identified API level changes in this PR and created the following API reviews

com.azure:azure-openrewrite
com.azure.tools:azure-sdk-archetype
com.azure.tools:azure-sdk-build-tool

@alzimmermsft alzimmermsft marked this pull request as ready for review January 12, 2026 14:44
Copilot AI review requested due to automatic review settings January 12, 2026 14:44
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs testing infrastructure cleanup by removing unnecessary test dependencies and updating testing tools for better Java 25 support.

Changes:

  • Upgraded Jacoco from 0.8.13 to 0.8.14 across all modules
  • Upgraded ASM (bytecode manipulation library) from 9.8 to 9.9.1 in parent POMs and build tools
  • Removed unused test dependencies: hamcrest-all, commons-compress, mockito-core, mockito-junit-jupiter, and wiremock-jre8

Reviewed changes

Copilot reviewed 82 out of 82 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Multiple pom.xml files Updated Jacoco version from 0.8.13 to 0.8.14 for test coverage
Parent pom.xml files Updated ASM version from 9.8 to 9.9.1 for bytecode processing
sdk/keyvault/azure-security-keyvault-jca/pom.xml Removed redundant Jacoco plugin configuration (inherited from parent)
sdk/identity/azure-identity-broker-samples/pom.xml Simplified Java 8 profile by using properties instead of explicit plugin configurations
sdk/core/azure-core-http-jdk-httpclient/pom.xml Simplified Java 8 profile by using properties instead of explicit plugin configurations
sdk/clientcore/core/pom.xml Removed unused commons-compress test dependency
sdk/appplatform/azure-resourcemanager-appplatform/pom.xml Removed commons-compress dependency and maven-enforcer-plugin configuration
sdk/appplatform/.../SpringCloudLiveOnlyTest.java Replaced commons-compress IOUtils.copy with custom copy method; removed unused extraTarGzSource method
sdk/communication/.../CallRecordingUnitTestBase.java Simplified JSON serialization using toJsonString() instead of JsonWriter
sdk/communication/.../pom.xml Removed hamcrest-all test dependency
sdk/ai/azure-ai-voicelive/pom.xml Removed mockito-core, mockito-junit-jupiter, and wiremock-jre8 test dependencies
Multiple test files in azure-ai-voicelive Removed mockito imports and @mock annotations; replaced with simple implementations
Multiple test files in azure-ai-voicelive Simplified JSON serialization/deserialization using toJsonString() and JsonProviders.createReader(String)
Multiple test files in azure-ai-voicelive Removed unnecessary IOException declarations from test methods
Multiple test files Reorganized imports to follow proper grouping and sorting order
Multiple test files Improved test assertions (assertNotEquals with null → assertNotNull)
sdk/communication/.../CHANGELOG.md Bumped version to 1.6.0-beta.2
eng/versioning/external_dependencies.txt Updated dependency versions and removed unused dependency entries
Comments suppressed due to low confidence (1)

sdk/communication/azure-communication-callautomation/CHANGELOG.md:11

  • The version was bumped to 1.6.0-beta.2 but the CHANGELOG does not document the changes made in this PR. Since this PR removes test dependencies and updates testing infrastructure, consider adding an entry under "Other Changes" section documenting the dependency cleanup and version updates for testing tools (Jacoco, ASM, etc.).
## 1.6.0-beta.2 (Unreleased)

### Features Added

### Breaking Changes

### Bugs Fixed

### Other Changes

Copy link
Member

@samvaity samvaity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Member

@rujche rujche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM about the 3 pom file updates in sdk/spring folder.

@alzimmermsft
Copy link
Member Author

/check-enforcer override

@alzimmermsft alzimmermsft merged commit 19e35e7 into Azure:main Jan 13, 2026
56 of 60 checks passed
@alzimmermsft alzimmermsft deleted the AzAll_GeneralTestCleanup branch January 13, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

4 participants