-
Notifications
You must be signed in to change notification settings - Fork 2.1k
General testing cleanup to remove dependencies #47662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General testing cleanup to remove dependencies #47662
Conversation
API Change CheckAPIView identified API level changes in this PR and created the following API reviews com.azure:azure-openrewrite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR performs testing infrastructure cleanup by removing unnecessary test dependencies and updating testing tools for better Java 25 support.
Changes:
- Upgraded Jacoco from 0.8.13 to 0.8.14 across all modules
- Upgraded ASM (bytecode manipulation library) from 9.8 to 9.9.1 in parent POMs and build tools
- Removed unused test dependencies: hamcrest-all, commons-compress, mockito-core, mockito-junit-jupiter, and wiremock-jre8
Reviewed changes
Copilot reviewed 82 out of 82 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Multiple pom.xml files | Updated Jacoco version from 0.8.13 to 0.8.14 for test coverage |
| Parent pom.xml files | Updated ASM version from 9.8 to 9.9.1 for bytecode processing |
| sdk/keyvault/azure-security-keyvault-jca/pom.xml | Removed redundant Jacoco plugin configuration (inherited from parent) |
| sdk/identity/azure-identity-broker-samples/pom.xml | Simplified Java 8 profile by using properties instead of explicit plugin configurations |
| sdk/core/azure-core-http-jdk-httpclient/pom.xml | Simplified Java 8 profile by using properties instead of explicit plugin configurations |
| sdk/clientcore/core/pom.xml | Removed unused commons-compress test dependency |
| sdk/appplatform/azure-resourcemanager-appplatform/pom.xml | Removed commons-compress dependency and maven-enforcer-plugin configuration |
| sdk/appplatform/.../SpringCloudLiveOnlyTest.java | Replaced commons-compress IOUtils.copy with custom copy method; removed unused extraTarGzSource method |
| sdk/communication/.../CallRecordingUnitTestBase.java | Simplified JSON serialization using toJsonString() instead of JsonWriter |
| sdk/communication/.../pom.xml | Removed hamcrest-all test dependency |
| sdk/ai/azure-ai-voicelive/pom.xml | Removed mockito-core, mockito-junit-jupiter, and wiremock-jre8 test dependencies |
| Multiple test files in azure-ai-voicelive | Removed mockito imports and @mock annotations; replaced with simple implementations |
| Multiple test files in azure-ai-voicelive | Simplified JSON serialization/deserialization using toJsonString() and JsonProviders.createReader(String) |
| Multiple test files in azure-ai-voicelive | Removed unnecessary IOException declarations from test methods |
| Multiple test files | Reorganized imports to follow proper grouping and sorting order |
| Multiple test files | Improved test assertions (assertNotEquals with null → assertNotNull) |
| sdk/communication/.../CHANGELOG.md | Bumped version to 1.6.0-beta.2 |
| eng/versioning/external_dependencies.txt | Updated dependency versions and removed unused dependency entries |
Comments suppressed due to low confidence (1)
sdk/communication/azure-communication-callautomation/CHANGELOG.md:11
- The version was bumped to 1.6.0-beta.2 but the CHANGELOG does not document the changes made in this PR. Since this PR removes test dependencies and updates testing infrastructure, consider adding an entry under "Other Changes" section documenting the dependency cleanup and version updates for testing tools (Jacoco, ASM, etc.).
## 1.6.0-beta.2 (Unreleased)
### Features Added
### Breaking Changes
### Bugs Fixed
### Other Changes
samvaity
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
rujche
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM about the 3 pom file updates in sdk/spring folder.
|
/check-enforcer override |
Description
Small code change PR to remove test dependencies that weren't necessary.
Also updates to Jacoco, Byte Buddy, and ASM dependencies for better Java 25 support.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines