adding test for trace_function decorator#45037
Merged
Conversation
dargilco
approved these changes
Feb 5, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive test coverage for the trace_function decorator, which is used to trace function calls using OpenTelemetry. The PR includes both synchronous and asynchronous test suites, along with minor improvements to the underlying implementation.
Changes:
- Added comprehensive test suite for synchronous functions with the
trace_functiondecorator - Added comprehensive test suite for asynchronous functions with the
trace_functiondecorator - Improved the implementation to use
inspect.iscoroutinefunctioninstead ofasyncio.iscoroutinefunction - Fixed the parameter sanitization logic to correctly handle positional arguments, keyword arguments, and default values
- Enhanced tracer initialization to occur at function execution time rather than decoration time
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| sdk/ai/azure-ai-projects/tests/agents/telemetry/test_trace_function_decorator.py | New test file with 13 comprehensive test cases for synchronous functions, covering primitives, collections, custom span names, exceptions, and mixed parameter types |
| sdk/ai/azure-ai-projects/tests/agents/telemetry/test_trace_function_decorator_async.py | New test file with 15 comprehensive test cases for asynchronous functions, mirroring sync tests plus additional coverage for default parameters |
| sdk/ai/azure-ai-projects/azure/ai/projects/telemetry/_trace_function.py | Implementation improvements: changed from asyncio to inspect for coroutine detection, moved tracer initialization to execution time, and fixed parameter handling logic |
sdk/ai/azure-ai-projects/tests/agents/telemetry/test_trace_function_decorator.py
Outdated
Show resolved
Hide resolved
sdk/ai/azure-ai-projects/tests/agents/telemetry/test_trace_function_decorator.py
Outdated
Show resolved
Hide resolved
sdk/ai/azure-ai-projects/tests/agents/telemetry/test_trace_function_decorator_async.py
Outdated
Show resolved
Hide resolved
nick863
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adding test for trace_function decorator