Skip to content

Dependencies filter available versions based on prerelease state of initial requirement #45043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scbedd merged 1 commit into from
Feb 5, 2026
+16 −18
Merged

Dependencies filter available versions based on prerelease state of initial requirement #45043

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 16 additions & 18 deletions eng/tox/install_depend_packages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"azure-storage-file-datalake": {"azure-storage-blob": "12.22.0"},
"azure-cosmos": {"azure-core": "1.30.0"},
"azure-appconfiguration-provider": {"azure-appconfiguration": "1.7.2"},
"azure-ai-evaluation": {"aiohttp": "3.8.6"}
"azure-ai-evaluation": {"aiohttp": "3.8.6"},
}

MAXIMUM_VERSION_SPECIFIC_OVERRIDES = {}
Expand All @@ -73,16 +73,8 @@
">=3.14.0": {
"typing-extensions": "4.15.0",
},
">=3.12.0": {
"azure-core": "1.23.1",
"aiohttp": "3.9.0",
"six": "1.16.0",
"requests": "2.30.0"
},
">=3.13.0": {
"typing-extensions": "4.13.0",
"aiohttp": "3.10.6"
}
">=3.12.0": {"azure-core": "1.23.1", "aiohttp": "3.9.0", "six": "1.16.0", "requests": "2.30.0"},
">=3.13.0": {"typing-extensions": "4.13.0", "aiohttp": "3.10.6"},
}

PLATFORM_SPECIFIC_MAXIMUM_OVERRIDES = {}
Expand Down Expand Up @@ -188,9 +180,7 @@ def process_bounded_versions(originating_pkg_name: str, pkg_name: str, versions:

# lower bound general
if pkg_name in MINIMUM_VERSION_GENERIC_OVERRIDES:
versions = [
v for v in versions if Version(v) >= Version(MINIMUM_VERSION_GENERIC_OVERRIDES[pkg_name])
]
versions = [v for v in versions if Version(v) >= Version(MINIMUM_VERSION_GENERIC_OVERRIDES[pkg_name])]

# lower bound platform-specific
for platform_bound in PLATFORM_SPECIFIC_MINIMUM_OVERRIDES.keys():
Expand All @@ -213,9 +203,7 @@ def process_bounded_versions(originating_pkg_name: str, pkg_name: str, versions:

# upper bound general
if pkg_name in MAXIMUM_VERSION_GENERIC_OVERRIDES:
versions = [
v for v in versions if Version(v) <= Version(MAXIMUM_VERSION_GENERIC_OVERRIDES[pkg_name])
]
versions = [v for v in versions if Version(v) <= Version(MAXIMUM_VERSION_GENERIC_OVERRIDES[pkg_name])]

# upper bound platform
for platform_bound in PLATFORM_SPECIFIC_MAXIMUM_OVERRIDES.keys():
Expand Down Expand Up @@ -256,11 +244,22 @@ def process_requirement(req, dependency_type, orig_pkg_name):
)
return ""

# if the specifier includes preview versions, then we can resolve preview versions
# otherwise, we should filter them out
allows_prereleases = spec is not None and spec.prereleases is True

# get available versions on PyPI
client = PyPIClient()
versions = [str(v) for v in client.get_ordered_versions(pkg_name, True)]
logging.info("Versions available on PyPI for %s: %s", pkg_name, versions)

# prepass filter before choosing a latest or minimum, eliminate prerelease versions if they are not allowed based on the specifier
if not allows_prereleases:
versions = [v for v in versions if not Version(v).is_prerelease]
logging.info(
"Filtered out pre-release versions for %s based on specifier. Remaining versions: %s", pkg_name, versions
)

# think of the various versions that come back from pypi as the top of a funnel
# We apply generic overrides -> platform specific overrides -> package specific overrides
versions = process_bounded_versions(orig_pkg_name, pkg_name, versions)
Expand Down Expand Up @@ -418,5 +417,4 @@ def install_packages(packages, req_file):
logging.error("Invalid arguments. Please make sure target directory and working directory are valid path")
sys.exit(1)


install_dependent_packages(setup_path, args.dependency_type, args.work_dir)
Loading