Skip to content

Move our Libraries to only use artifact feed for packages, no Maven Central, Fixes AB#3395409 #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fadidurah merged 11 commits into from
Dec 11, 2025
Merged

Move our Libraries to only use artifact feed for packages, no Maven Central, Fixes AB#3395409 #385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
cf9d7fa
maven central
fadidurah Dec 3, 2025
e350300
new feed
fadidurah Dec 5, 2025
8cffaa9
update
fadidurah Dec 5, 2025
0a9b84c
revert version
fadidurah Dec 5, 2025
549ce64
comments
fadidurah Dec 5, 2025
1325d99
update
fadidurah Dec 6, 2025
efd561f
keep google()
fadidurah Dec 6, 2025
e2229ed
add feed
fadidurah Dec 6, 2025
149eb7d
vstsMavenAccessToken
fadidurah Dec 8, 2025
80f80aa
consolidate vsts variables
fadidurah Dec 9, 2025
482eca5
final parts
fadidurah Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,17 @@ buildscript {
*/

repositories {
// If you don't have access to the package feed below, uncomment the maven central repo
// mavenCentral()
mavenLocal()
google()
mavenCentral()
maven {
// msazure and aria are consumed via upstream sources of the AndroidADAL feed.
name "vsts-maven-adal-android"
url "https://identitydivision.pkgs.visualstudio.com/_packaging/AndroidADAL/maven/v1"
// msazure and aria are consumed via upstream sources of the NewAndroid feed.
name "vsts-maven-new-android"
url "https://identitydivision.pkgs.visualstudio.com/_packaging/NewAndroid/maven/v1"
credentials {
username System.getenv("ENV_VSTS_MVN_ANDROID_MSAL_USERNAME") != null ? System.getenv("ENV_VSTS_MVN_ANDROID_MSAL_USERNAME") : project.findProperty("vstsUsername")
password System.getenv("ENV_VSTS_MVN_ANDROIDADACCOUNTS_ACCESSTOKEN") != null ? System.getenv("ENV_VSTS_MVN_ANDROIDADACCOUNTS_ACCESSTOKEN") : project.findProperty("vstsMavenAccessToken")
username System.getenv("ENV_VSTS_MVN_CRED_USERNAME") != null ? System.getenv("ENV_VSTS_MVN_CRED_USERNAME") : project.findProperty("vstsUsername")
password System.getenv("ENV_VSTS_MVN_CRED_ACCESSTOKEN") != null ? System.getenv("ENV_VSTS_MVN_CRED_ACCESSTOKEN") : project.findProperty("vstsMavenAccessToken")
}
}
}
Expand All @@ -44,21 +46,19 @@ plugins {
id "com.microsoft.hydralab.client-util" version "1.1.14"
}

project.ext.vstsUsername = System.getenv("ENV_VSTS_MVN_ANDROID_MSAL_USERNAME") != null ? System.getenv("ENV_VSTS_MVN_ANDROID_MSAL_USERNAME") : project.findProperty("vstsUsername")
project.ext.vstsMavenAccessToken = System.getenv("ENV_VSTS_MVN_ANDROIDADACCOUNTS_ACCESSTOKEN") != null ? System.getenv("ENV_VSTS_MVN_ANDROIDADACCOUNTS_ACCESSTOKEN") : project.findProperty("vstsMavenAccessToken")
project.ext.vstsUsername = System.getenv("ENV_VSTS_MVN_CRED_USERNAME") != null ? System.getenv("ENV_VSTS_MVN_CRED_USERNAME") : project.findProperty("vstsUsername")
project.ext.vstsMavenAccessToken = System.getenv("ENV_VSTS_MVN_CRED_ACCESSTOKEN") != null ? System.getenv("ENV_VSTS_MVN_CRED_ACCESSTOKEN") : project.findProperty("vstsMavenAccessToken")

allprojects {
repositories {
mavenLocal()
google()
mavenCentral()
maven {
url 'https://pkgs.dev.azure.com/MicrosoftDeviceSDK/DuoSDK-Public/_packaging/Duo-SDK-Feed/maven/v1'
}
// If you don't have access to the package feed uncomment the maven central repo
// mavenCentral()
maven {
// msazure and aria are consumed via upstream sources of the AndroidADAL feed.
name "vsts-maven-adal-android"
url "https://identitydivision.pkgs.visualstudio.com/_packaging/AndroidADAL/maven/v1"
// msazure and aria are consumed via upstream sources of the NewAndroid feed.
name "vsts-maven-new-android"
url "https://identitydivision.pkgs.visualstudio.com/_packaging/NewAndroid/maven/v1"
credentials {
username project.vstsUsername
password project.vstsMavenAccessToken
Expand Down
27 changes: 17 additions & 10 deletions java-complete/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,21 @@
project.ext.vstsUsername = System.getenv("ENV_VSTS_MVN_ANDROID_MSAL_USERNAME") != null ? System.getenv("ENV_VSTS_MVN_ANDROID_MSAL_USERNAME") : project.findProperty("vstsUsername")
project.ext.vstsMavenAccessToken = System.getenv("ENV_VSTS_MVN_ANDROIDADACCOUNTS_ACCESSTOKEN") != null ? System.getenv("ENV_VSTS_MVN_ANDROIDADACCOUNTS_ACCESSTOKEN") : project.findProperty("vstsMavenAccessToken")
project.ext.vstsUsername = System.getenv("ENV_VSTS_MVN_CRED_USERNAME") != null ? System.getenv("ENV_VSTS_MVN_CRED_USERNAME") : project.findProperty("vstsUsername")
project.ext.vstsMavenAccessToken = System.getenv("ENV_VSTS_MVN_CRED_ACCESSTOKEN") != null ? System.getenv("ENV_VSTS_MVN_CRED_ACCESSTOKEN") : project.findProperty("vstsMavenAccessToken")
buildscript {
apply from: rootProject.file("../gradle/versions.gradle")

repositories {
// If you don't have access to the package feed below, uncomment the maven central repo
Copy link
Contributor

@shahzaibj shahzaibj Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why might someone not have access to this feed?

Copy link
Contributor Author

@fadidurah fadidurah Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They need an access token for identity division no? What if it's a third party customer? Might not be applicable for android-compelte or broker, but it would be for msal/common. i decided to add it everywhere to be consistent, in case some internal users don't have access to the feed but want to build.

// mavenCentral()
google()
mavenCentral()
maven {
// msazure and aria are consumed via upstream sources of the NewAndroid feed.
name "vsts-maven-new-android"
url "https://identitydivision.pkgs.visualstudio.com/_packaging/NewAndroid/maven/v1"
credentials {
username project.vstsUsername
password project.vstsMavenAccessToken
}
}
}

dependencies {
Expand All @@ -15,16 +25,13 @@ buildscript {

allprojects {
repositories {
// If you don't have access to the package feed below, uncomment the maven central repo
// mavenCentral()
mavenLocal()
google()
mavenCentral()
maven {
url 'https://pkgs.dev.azure.com/MicrosoftDeviceSDK/DuoSDK-Public/_packaging/Duo-SDK-Feed/maven/v1'
}
maven {
// msazure and aria are consumed via upstream sources of the AndroidADAL feed.
name "vsts-maven-adal-android"
url "https://identitydivision.pkgs.visualstudio.com/_packaging/AndroidADAL/maven/v1"
name "vsts-maven-new-android"
url "https://identitydivision.pkgs.visualstudio.com/_packaging/NewAndroid/maven/v1"
credentials {
username project.vstsUsername
password project.vstsMavenAccessToken
Expand Down
13 changes: 11 additions & 2 deletions java-complete/settings.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,20 @@
*/
pluginManagement {
repositories {
// If you don't have access to the package feed below, uncomment the maven central repo
// mavenCentral()
mavenLocal()
google()
mavenCentral()
gradlePluginPortal()
maven {
// msazure and aria are consumed via upstream sources of the NewAndroid feed.
name "vsts-maven-new-android"
url "https://identitydivision.pkgs.visualstudio.com/_packaging/NewAndroid/maven/v1"
credentials {
username System.getenv("ENV_VSTS_MVN_CRED_USERNAME") != null ? System.getenv("ENV_VSTS_MVN_CRED_USERNAME") : vstsUsername
password System.getenv("ENV_VSTS_MVN_CRED_ACCESSTOKEN") != null ? System.getenv("ENV_VSTS_MVN_CRED_ACCESSTOKEN") : vstsMavenAccessToken
}
}
}
}

Expand Down Expand Up @@ -44,4 +54,3 @@ project(':java-linux-test-app').projectDir = new File('../broker/java-linux-test

include(':LabApiUtilities')
project(':LabApiUtilities').projectDir = new File('../common/LabApiUtilities')

8 changes: 8 additions & 0 deletions plugins/buildsystem/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,14 @@ repositories {
mavenCentral()
google()
gradlePluginPortal()
maven {
name "vsts-maven-new-android"
url "https://identitydivision.pkgs.visualstudio.com/_packaging/NewAndroid/maven/v1"
credentials {
username System.getenv("ENV_VSTS_MVN_CRED_USERNAME") != null ? System.getenv("ENV_VSTS_MVN_CRED_USERNAME") : project.findProperty("vstsUsername")
password System.getenv("ENV_VSTS_MVN_CRED_ACCESSTOKEN") != null ? System.getenv("ENV_VSTS_MVN_CRED_ACCESSTOKEN") : project.findProperty("vstsMavenAccessToken")
}
}
}

dependencies {
Expand Down
13 changes: 7 additions & 6 deletions settings.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,16 @@ pluginManagement {
repositories {
mavenLocal()
google()
mavenCentral()
// If you don't have access to the package feed below, uncomment the maven central repo
// mavenCentral()
gradlePluginPortal()
maven {
// msazure and aria are consumed via upstream sources of the AndroidADAL feed.
name "vsts-maven-adal-android"
url "https://identitydivision.pkgs.visualstudio.com/_packaging/AndroidADAL/maven/v1"
// msazure and aria are consumed via upstream sources of the NewAndroid feed.
name "vsts-maven-new-android"
url "https://identitydivision.pkgs.visualstudio.com/_packaging/NewAndroid/maven/v1"
credentials {
username System.getenv("ENV_VSTS_MVN_ANDROID_MSAL_USERNAME") != null ? System.getenv("ENV_VSTS_MVN_ANDROID_MSAL_USERNAME") : vstsUsername
password System.getenv("ENV_VSTS_MVN_ANDROIDADACCOUNTS_ACCESSTOKEN") != null ? System.getenv("ENV_VSTS_MVN_ANDROIDADACCOUNTS_ACCESSTOKEN") : vstsMavenAccessToken
username System.getenv("ENV_VSTS_MVN_CRED_USERNAME") != null ? System.getenv("ENV_VSTS_MVN_CRED_USERNAME") : vstsUsername
password System.getenv("ENV_VSTS_MVN_CRED_ACCESSTOKEN") != null ? System.getenv("ENV_VSTS_MVN_CRED_ACCESSTOKEN") : vstsMavenAccessToken
}
}
}
Expand Down