feat: 분실물 API Controller 분리 및 분실물 조회 API 필터 추가 #2130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DHkimgit
requested review from
BaeJinho4028,
ImTotem,
Soundbar91,
asa9874,
dh2906,
kih1015 and
taejinn
dh2906
approved these changes
Jan 15, 2026
Comment on lines
93
to
94
| @Parameter(description = "게시글 제목") | ||
| @RequestParam(required = false) String query, |
Contributor
There was a problem hiding this comment.
Suggested change
| @Parameter(description = "게시글 제목") | |
| @RequestParam(required = false) String query, | |
| @Parameter(description = "게시글 제목") | |
| @RequestParam(required = false) String title, |
명세에 게시글 제목이라 되어있으니 네이밍을 수정하는건 어떤가요??
Comment on lines
120
to
125
| @Operation(summary = "분실물 게시글 등록") | ||
| @PostMapping("/lost-item") | ||
| ResponseEntity<LostItemArticleResponse> createLostItemArticle( | ||
| @Auth(permit = {STUDENT, COUNCIL}) Integer userId, | ||
| @RequestBody @Valid LostItemArticlesRequest lostItemArticlesRequest | ||
| ); |
Contributor
There was a problem hiding this comment.
구현체와 권한 허용이 다르게 나와있어요!
구현체에서는 @Auth(permit = {GENERAL, STUDENT, COUNCIL})으로 되어있어서 확인 부탁드립니당
Comment on lines
136
to
141
| @Operation(summary = "분실물 게시글 삭제") | ||
| @DeleteMapping("/lost-item/{id}") | ||
| ResponseEntity<Void> deleteLostItemArticle( | ||
| @PathVariable("id") Integer articleId, | ||
| @Auth(permit = {STUDENT, COUNCIL}) Integer councilId | ||
| ); |
Comment on lines
36
to
38
| @Service | ||
| @RequiredArgsConstructor | ||
| public class LostItemArticleService { |
Contributor
There was a problem hiding this comment.
@Transactional(readOnly=true)가 빠진 것 같아요
ImTotem
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 개요
🚀 주요 변경 내용
1. 분실물 게시글 동적 조회 GET API에 여러 동적 필터가 추가
API 설명
2. “찾는중” 상태인 분실물 게시글 개수 반환 GET API 추가
API 설명
요청 정보
응답 예시(200)
{ "not_found_count": 2 }3. 분실물 게시글 관련 API 엔트포인트 컨트롤러 분리
💬 참고 사항
✅ Checklist (완료 조건)