Skip to content

fix: 탈퇴한 사용자와 채팅 시도 시 발생하는 NPE 수정 #2132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DHkimgit merged 4 commits into from
Jan 16, 2026
Merged

fix: 탈퇴한 사용자와 채팅 시도 시 발생하는 NPE 수정 #2132

DHkimgit merged 4 commits into from
Jan 16, 2026
+25 −1

Conversation

@DHkimgit
Copy link
Collaborator

@DHkimgit DHkimgit commented Jan 15, 2026 •
edited
Loading

🔍 개요

Exception: NullPointerExceptionLocation: LostItemArticleInfoService.java Line 34Cannot invoke "in.koreatech.koin.domain.user.model.User.getProfileImageUrl()" because the return value of "in.koreatech.koin.domain.community.article.model.LostItemArticle.getAuthor()" is null

🚀 주요 변경 내용

  • 404 예외 처리
{
  "message": "분실물 게시글 채팅방이 존재하지 않습니다.",
  "errorTraceId": "123e4567-e89b-12d3-a456-426614174000",
  "code": "NOT_FOUND_CHAT_PARTNER"
}

💬 참고 사항

  • 회원 탈퇴시 작성한 분실물 게시글 + 채팅방 처리와 관련한 비즈니스 로직 필요

✅ Checklist (완료 조건)

  • 코드 스타일 가이드 준수
  • 테스트 코드 포함됨
  • Reviewers / Assignees / Labels 지정 완료
  • 보안 및 민감 정보 검증 (API 키, 환경 변수, 개인정보 등)

@DHkimgit DHkimgit self-assigned this Jan 15, 2026
@DHkimgit DHkimgit added 버그 정상적으로 동작하지 않는 문제상황입니다. Team Campus 캠퍼스 팀에서 작업할 이슈입니다 labels Jan 15, 2026
@github-actions
Copy link

github-actions bot commented Jan 15, 2026 •
edited
Loading

Unit Test Results

673 tests   670 ✔️  1m 14s ⏱️
165 suites      3 💤
165 files        0 ❌

Results for commit f0619db.

♻️ This comment has been updated with latest results.

dh2906
dh2906 approved these changes Jan 15, 2026
View reviewed changes
Copy link
Contributor

@dh2906 dh2906 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니당

...in/koreatech/koin/domain/community/lostitem/chatroom/service/LostItemArticleInfoService.java Outdated
Comment on lines 37 to 39
return Optional.ofNullable(lostItemArticle.getAuthor())
.map(User::getProfileImageUrl)
.orElseThrow(() -> CustomException.of(ApiResponseCode.NOT_FOUND_CHAT_PARTNER));
Copy link
Contributor

@dh2906 dh2906 Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

유저의 profileImageUrl이 null인 경우는 404가 터지는 로직 같은데, 현재 거의 모든 유저는 이미지가 없어서 거의 무조건 터지지 않나요?? 👀

Copy link
Collaborator Author

@DHkimgit DHkimgit Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헐 다 null로 들어가있네요

kih1015
kih1015 approved these changes Jan 16, 2026
View reviewed changes
Copy link
Contributor

@kih1015 kih1015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~

@DHkimgit DHkimgit merged commit de47818 into develop Jan 16, 2026
5 checks passed
@DHkimgit DHkimgit deleted the fix/2131-getLostItemChatRoom-NPE branch January 16, 2026 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dh2906 dh2906 dh2906 approved these changes

@kih1015 kih1015 kih1015 approved these changes

@ImTotem ImTotem Awaiting requested review from ImTotem

@BaeJinho4028 BaeJinho4028 Awaiting requested review from BaeJinho4028

@Soundbar91 Soundbar91 Awaiting requested review from Soundbar91

@taejinn taejinn Awaiting requested review from taejinn

@duehee duehee Awaiting requested review from duehee

@krSeonghyeon krSeonghyeon Awaiting requested review from krSeonghyeon

Assignees

@DHkimgit DHkimgit

Labels

Team Campus 캠퍼스 팀에서 작업할 이슈입니다 버그 정상적으로 동작하지 않는 문제상황입니다.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[캠퍼스] getLostItemChatRoom API NPE 대응

4 participants

@DHkimgit @dh2906 @kih1015