fix: 상시 모집에 대한 상태 처리 추가 #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dh2906
added
기능
There was a problem hiding this comment.
Pull request overview
This PR fixes a NullPointerException in the RecruitmentStatus.of() method when handling always-recruiting clubs. The issue occurred because the method attempted to use startDate and endDate before checking if the recruitment was always-recruiting or if those fields were null.
Changes:
- Added early return for always-recruiting clubs before accessing date fields
- Added null safety checks for startDate and endDate to prevent NPE
- Extracted date fields to local variables for cleaner code
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 개요
🚀 주요 변경 내용
RecruitmentStatus의of()메소드로 상태 판별 시 NPE가 발생하는 문제를 해결했습니다.💬 참고 사항
✅ Checklist (완료 조건)