Skip to content

Conversation

@dh2906
Copy link
Contributor

@dh2906 dh2906 commented Jan 14, 2026

🔍 개요


🚀 주요 변경 내용

  • GET /clubs/{clubId}/applications/{applicationId} 엔드포인트를 추가했습니다.

  • 특정 지원서의 내용을 상세히 조회할 수 있습니다.

  • 만약, 선택 문항에 대해 답변을 하지 않은 경우 답변 내용이 null로 나옵니다.

{
  "applicationId": 11,
  "studentNumber": "20250040",
  "name": "이동훈",
  "appliedAt": "2026-01-14T11:05:03",
  "answers": [
    {
      "questionId": 8,
      "question": "지원 동기를 입력해주세요.",
      "isRequired": true,
      "answer": "동아리 활동을 통해 성장하고 싶습니다."
    },
    {
      "questionId": 9,
      "question": "동아리에서 기대하는 점을 적어주세요.",
      "isRequired": false,
      "answer": null
    }
  ]
}

💬 참고 사항


✅ Checklist (완료 조건)

  • 코드 스타일 가이드 준수
  • 테스트 코드 포함됨
  • Reviewers / Assignees / Labels 지정 완료
  • 보안 및 민감 정보 검증 (API 키, 환경 변수, 개인정보 등)

@dh2906 dh2906 requested a review from Copilot January 14, 2026 02:37
@dh2906 dh2906 self-assigned this Jan 14, 2026
@dh2906 dh2906 added the 기능 새로운 기능을 개발합니다. label Jan 14, 2026
@github-actions
Copy link

⚠️ Checkstyle 위반 사항 발견

Checkstyle 검사에서 코딩 컨벤션 위반이 발견되었습니다.

📋 상세 리포트

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds an API endpoint to retrieve detailed information for a specific club application. The implementation enables club managers to view individual application answers, including handling of optional questions where answers may be null.

Changes:

  • Added GET /clubs/{clubId}/applications/{applicationId} endpoint for retrieving detailed application answers
  • Implemented repository methods with JOIN FETCH to efficiently load related entities
  • Added response DTO to format application details including question-answer pairs

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/main/resources/config Updated subproject commit reference
src/main/java/gg/agit/konect/global/code/ApiResponseCode.java Added NOT_FOUND_CLUB_APPLY error code
src/main/java/gg/agit/konect/domain/club/service/ClubService.java Implemented getClubApplicationAnswers service method with authorization check
src/main/java/gg/agit/konect/domain/club/repository/ClubApplyRepository.java Added findByIdAndClubId query method with user JOIN FETCH
src/main/java/gg/agit/konect/domain/club/repository/ClubApplyAnswerRepository.java Added findAllByApplyIdWithQuestion query method with question JOIN FETCH
src/main/java/gg/agit/konect/domain/club/dto/ClubApplicationAnswersResponse.java Created response DTO with nested answer response and mapping logic
src/main/java/gg/agit/konect/domain/club/controller/ClubController.java Implemented controller method to handle GET request
src/main/java/gg/agit/konect/domain/club/controller/ClubApi.java Added API specification with operation documentation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dh2906 dh2906 merged commit a44b6cb into main Jan 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

기능 새로운 기능을 개발합니다.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants