Another attempt at a fix for #1094 #1099
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is terrible and increases the CPU load due to having to loop over the inventory up to two times if the event was cancelled. That being said though, I wasn't able to have issues when `fix-stack` was set to true or false.
Member
|
Not accepting this, will cause lag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is terrible and increases the CPU load due to having to loop over the inventory up to two times if the event was cancelled.
That being said though, I wasn't able to have issues when
fix-stackwas set to true or false.If this doesn't get merged, I recommend reverting my previous attempt as that causes more issues than it fixes. Overall this is just a hacky fix until a better solution is found. Unfortunately I don't understand this plugin enough to provide one.