Add OpenGL external texture support#1439
Closed
kmatzen wants to merge 5 commits intoBabylonJS:masterfrom
Closed
Conversation
bghgary
reviewed
Oct 4, 2024
bghgary
approved these changes
Oct 8, 2024
Contributor
bghgary
left a comment
bghgary
left a comment
There was a problem hiding this comment.
Looks good. We unfortunately do not have testing for this class yet. I'm assuming this code works in your scenario?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started with the ExternalTexture for Metal and had an LLM convert it to OpenGL. I fixed up a few parts where it made mistakes in the texture enums, then eyeballed the rest.