Updated to Transmission RPC specification as of Transmission 4.1.0#26
Open
Jdbye wants to merge 5 commits intoBeatlegger:masterfrom
Open
Updated to Transmission RPC specification as of Transmission 4.1.0#26Jdbye wants to merge 5 commits intoBeatlegger:masterfrom
Jdbye wants to merge 5 commits intoBeatlegger:masterfrom
Conversation
* All new methods implemented * All new fields readable * "format" optional parameter of torrent-get remains unimplemented, for now. This is not needed but provides some efficiency benefits if the "table" format type is implemented.
…clarity, added TorrentGetRecentlyActive Also added missing summaries to get rid of those pesky warnings from Visual Studio
* Significantly more performant (around 20% when fetching a large amount of torrents with torrent-get) * torrent-get now supports the table format. This by itself only provides a small speed improvement. * RPC requests no longer need to deserialize->serialize->deserialize the JSON to arrive at the final result. Once is enough.
It didn't read all the fields correctly and there was very minimal improvement in performance anyway.
Author
|
Made some significant performance improvements (about 20%) by removing the repeated Deserialize and Serialize calls in order to read the arguments. Attempted table format support for torrent-get was a failure and does not seem worth the trouble fixing for the minor performance gains (a few % at most) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added all the missing fields, 2 new methods (group-set and group-get) and the missing torrent-reannounce method, and added the optional fields argument for session-get.