Skip to content

Conversation

@ducky64
Copy link
Collaborator

@ducky64 ducky64 commented Sep 3, 2025

Add PowerSO8 / DFN5x6 FET pinnings using the generic footprint and add package names for JLC parts tables. The naming is a mess, but the all should be compatible packages.

Note that there are so few of these in the JLC table that they do not get picked in practice in any of the examples.

@ducky64 ducky64 requested a review from Copilot September 3, 2025 08:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Expands FET package support by adding PowerSO8 and DFN5x6 package variants to the JLC parts table. The change maps various naming conventions for these packages to a standardized footprint and updates the pinout mapping to support the generic PQFN footprint.

  • Added 19 new package name mappings for PowerSO8/DFN5x6 FET variants
  • Updated pinout definition to support the generic PQFN-8-EP_6x5mm_P1.27mm footprint
  • Mapped all package variants to the same generic footprint for compatibility

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
edg/parts/JlcFet.py Adds package name mappings for PowerSO8/DFN5x6 variants to the PACKAGE_FOOTPRINT_MAP
edg/abstract_parts/AbstractFets.py Updates pinout mapping to support both PowerPAK_SO-8_Single and PQFN-8-EP_6x5mm_P1.27mm_Generic footprints

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +41 to +44
(
'Package_SO:PowerPAK_SO-8_Single',
'Package_DFN_QFN:PQFN-8-EP_6x5mm_P1.27mm_Generic',
): lambda block: {
Copy link

Copilot AI Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a tuple as a dictionary key for multiple footprints reduces readability and maintainability. Consider using separate dictionary entries for each footprint to make the mapping more explicit and easier to understand.

Copilot uses AI. Check for mistakes.
@ducky64 ducky64 merged commit d07a176 into master Sep 3, 2025
12 checks passed
@ducky64 ducky64 deleted the powerso8 branch September 3, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants