Update main.yml #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the default shell for non-system users on Linux OS is /bin/sh, which does not serve much... /bin/bash is much more useful if you want to work with this user.
Owner
|
@MaxiReglisse thank you for your contribution! I think the name of the step "add docker users" is misleading. This just add the group docker to existing user. I don't think it's a good idea to change default shell in this role. |
Owner
|
Or better check that user exists before, because, well, it's not intended to create users. My bad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the default shell for non-system users on Linux OS is /bin/sh, which does not serve much... /bin/bash is much more useful if you want to work with this user.