Feature #56: count attributes on tags#65
Open
sonicaks wants to merge 2 commits intoBhupesh-V:masterfrom
Open
Conversation
sonicaks
commented
Oct 14, 2019
sonicaks
commented
- Annotate method is used to get the count of tags
Owner
|
Looks Good 👍 |
Collaborator
|
It works, but it looks like this: |
Author
|
@Animesh-Ghosh isn't it supposed to be done like that? |
Collaborator
|
Maybe change some styling in the template? It looks weird otherwise. @Bhupesh-V what do you think? |
Author
|
@Animesh-Ghosh I don't find anything weird about it. Just an extra number denoting count was added to the tags that's all. I haven't played anything with the names of tags. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.