Skip to content

Fix endpoint for updating message templates #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ahriman wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix endpoint for updating message templates #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
708472a
Fix update message template endpoint
Ahriman May 23, 2024
12920af
Merge pull request #1 from Ahriman/fix-update-message-template-endpoint
Ahriman May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/main/java/com/whatsapp/api/impl/WhatsappBusinessManagementApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,14 +67,13 @@ public Template createMessageTemplate(String whatsappBusinessAccountId, MessageT
/**
* Update message template message template id response.
*
* @param whatsappBusinessAccountId the whatsapp business account id
* @param messageTemplateId the message template id
* @param messageTemplate the message template
* @return the message template id response
*/
public Template updateMessageTemplate(String whatsappBusinessAccountId, String messageTemplateId, MessageTemplate messageTemplate) {
public Template updateMessageTemplate(String messageTemplateId, MessageTemplate messageTemplate) {

return executeSync(whatsappBusinessManagementApiService.updateMessageTemplate(apiVersion.getValue(), whatsappBusinessAccountId, messageTemplateId, messageTemplate));
return executeSync(whatsappBusinessManagementApiService.updateMessageTemplate(apiVersion.getValue(), messageTemplateId, messageTemplate));
}

/**
Expand Down
5 changes: 2 additions & 3 deletions src/main/java/com/whatsapp/api/service/WhatsappBusinessManagementApiService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,12 @@ public interface WhatsappBusinessManagementApiService {
/**
* Update message template call.
*
* @param whatsappBusinessAccountId the whatsapp business account id
* @param messageTemplateId the message template id
* @param messageTemplate the message template
* @return the call
*/
@POST("/{api-version}/{whatsapp-business-account-ID}/message_templates/{message-template-id}")
Call<Template> updateMessageTemplate(@Path("api-version") String apiVersion, @Path("whatsapp-business-account-ID") String whatsappBusinessAccountId, @Path("message-template-id") String messageTemplateId, @Body MessageTemplate messageTemplate);
@POST("/{api-version}/{message-template-id}")
Call<Template> updateMessageTemplate(@Path("api-version") String apiVersion, @Path("message-template-id") String messageTemplateId, @Body MessageTemplate messageTemplate);

/**
* Delete message template call.
Expand Down
3 changes: 1 addition & 2 deletions src/test/java/com/whatsapp/api/examples/UpdateMessageTemplateExample.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
import com.whatsapp.api.impl.WhatsappBusinessManagementApi;

import static com.whatsapp.api.TestConstants.TOKEN;
import static com.whatsapp.api.TestConstants.WABA_ID;

public class UpdateMessageTemplateExample {

Expand All @@ -34,7 +33,7 @@ public static void main(String[] args) {
.addBodyTextExamples("Mr. José", "satisfaction")//
))//
;
whatsappBusinessCloudApi.updateMessageTemplate(WABA_ID, "1144996326396573", template);
whatsappBusinessCloudApi.updateMessageTemplate("1144996326396573", template);
}

}
4 changes: 2 additions & 2 deletions src/test/java/com/whatsapp/api/impl/WhatsappBusinessManagementApiTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ void testCreateMessageTemplateMarketing2() throws IOException, URISyntaxExceptio
}

/**
* Method under test: {@link WhatsappBusinessManagementApi#updateMessageTemplate(String, String, MessageTemplate)}
* Method under test: {@link WhatsappBusinessManagementApi#updateMessageTemplate(String, MessageTemplate)}
*/
@Test
void testUpdateMessageTemplate() throws IOException, URISyntaxException
Expand All @@ -423,7 +423,7 @@ void testUpdateMessageTemplate() throws IOException, URISyntaxException
.addBodyTextExamples("Mr. José", "satisfaction")//
));

var response = whatsappBusinessCloudApi.updateMessageTemplate(WABA_ID, "952305634123456", template);
var response = whatsappBusinessCloudApi.updateMessageTemplate("952305634123456", template);

Assertions.assertEquals("952305634123456", response.id());
}
Expand Down