Solver #12
Open
Solver #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Class for storing numerical arrays between iterations. Add iterative fd solver Constraint update at each iteration. Add test for iterative solver Lint remove whitespace after unpacking operator Lint clean whitespace update python req to >= 3.7 Update build versions remove python version 3.6 Add mesh iterative solver Clean mesh iterative solver Add failsafe for residuals fix residuals checking Clean Refactor for general readability.
Base solver manager class for running iterative algorithms, storing numerical data, and results
Relocate and refactor with base class and FD specific class
Call new solver backend implementation
Reference updated solver backend
Change responsibility to post-process from solver to lazy calculation in FDNumericalData
Change from dataclass to regular class
Change FDNumericalData from dataclass into regular class with lazy calculation of property variables. Implicit recalculation of dependent variables. Add shorthand aliases to numerical arrays.
Abstract fd convenience functions, by implementing Solver and FDNumericalData backends.
Change scripts to call new implementations through Solvers and FDNumericalData.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For discussion: Added abstract Solver class.
Relocated NumericalData and Result classes to same folder level.
Refactored test scripts for new Solver backends.