Elements and Interactions #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomvanmele
reviewed
Jan 20, 2025
Collaborator
tomvanmele
left a comment
tomvanmele
left a comment
There was a problem hiding this comment.
- geometric definition of simple elements seems unnecessarily complicated (why not use a box to define the base geometry of a beam and column?)
- aabb, obb, collision mesh are expected to be in model geometry
- please use a formatter
tomvanmele
reviewed
Jan 20, 2025
| raise ValueError("Modifier type is not defined, please define a modifier type e.g. SlicerModfier.") | ||
|
|
||
| if issubclass(modifier_type, BooleanModifier): | ||
| return BooleanModifier(self.elementgeometry.transformed(self.modeltransformation)) |
Collaborator
There was a problem hiding this comment.
is self.elementgeometry.transformed(self.modeltransformation) not the same as self.modelgeometry?
Collaborator
Author
There was a problem hiding this comment.
I do not want here to trigger the cache.
Comment on lines
210
to
236
| def _create_slicer_modifier(self, target_element: "BeamElement") -> Modifier: | ||
| mesh = self.elementgeometry.transformed(self.modeltransformation) | ||
| center_line = target_element.center_line.transformed(target_element.modeltransformation) | ||
|
|
||
| p0 = center_line.start | ||
| p1 = center_line.end | ||
|
|
||
| closest_distance_to_end_point = float("inf") | ||
| closest_face = 0 | ||
| for face in self.elementgeometry.faces(): | ||
| polygon = mesh.face_polygon(face) | ||
| frame = polygon.frame | ||
| result = intersection_line_plane(center_line, Plane.from_frame(frame)) | ||
| if result: | ||
| point = Point(*result) | ||
| xform = Transformation.from_frame_to_frame(frame, Frame.worldXY()) | ||
| point = point.transformed(xform) | ||
| polygon = polygon.transformed(xform) | ||
| if is_point_in_polygon_xy(point, polygon): | ||
| d = max(p0.distance_to_point(point), p1.distance_to_point(point)) | ||
| if d < closest_distance_to_end_point: | ||
| closest_distance_to_end_point = d | ||
| closest_face = face | ||
|
|
||
| plane = Plane.from_frame(mesh.face_polygon(closest_face).frame) | ||
| plane = Plane(plane.point, -plane.normal) | ||
| return SlicerModifier(plane) |
Collaborator
There was a problem hiding this comment.
can you not just define the cutting plane using the box frame in model coordinates and the information about the connectivity about the beams?
Collaborator
Author
There was a problem hiding this comment.
I was trying to do Mesh and Ray (center-line) collision here, to use it for inclined cases too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elements: beam, column, plate and interactions types: contact, collision, modifier.
What type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas.datastructures.Mesh.