Adding Group and viewer objects #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Licini
requested review from
petrasvestartas and
tomvanmele
and removed request for
tomvanmele
Licini
commented
Apr 1, 2025
Comment on lines
+1
to
+40
| from compas.geometry import Polygon | ||
| from compas.geometry import Translation | ||
| from compas_model.elements import BeamElement | ||
| from compas_model.elements import PlateElement | ||
| from compas_model.models import Model | ||
| from compas_viewer import Viewer | ||
|
|
||
| beam1 = BeamElement(0.2, 0.3, 3) | ||
| beam2 = BeamElement(0.2, 0.3, 3) | ||
| beam3 = BeamElement(0.2, 0.3, 3) | ||
| beam4 = BeamElement(0.2, 0.3, 3) | ||
|
|
||
| beam1.transformation = Translation.from_vector([3, 3, 0]) | ||
| beam2.transformation = Translation.from_vector([-3, 3, 0]) | ||
| beam3.transformation = Translation.from_vector([-3, -3, 0]) | ||
| beam4.transformation = Translation.from_vector([3, -3, 0]) | ||
|
|
||
|
|
||
| points: list[list[float]] = [ | ||
| [-3, -3, 0], | ||
| [-3, 3, 0], | ||
| [3, 3, 0], | ||
| [3, -3, 0], | ||
| ] | ||
| polygon: Polygon = Polygon(points) | ||
| plate = PlateElement(polygon=polygon, thickness=0.2) | ||
| plate.transformation = Translation.from_vector([0, 0, 3]) | ||
|
|
||
| model = Model() | ||
| group = model.add_group(name="Beams") | ||
| model.add_element(beam1, parent=group) | ||
| model.add_element(beam2, parent=group) | ||
| model.add_element(beam3, parent=group) | ||
| model.add_element(beam4, parent=group) | ||
| model.add_element(plate) | ||
|
|
||
| # Vizualize. | ||
| viewer = Viewer() | ||
| viewer.scene.add(model) | ||
| viewer.show() |
Collaborator
Author
There was a problem hiding this comment.
This is the intended API usage. Basically aligns to BlockResearchGroup/compas-Masonry#11
And at the end, we directly add the entire model to the viewer.
Collaborator
There was a problem hiding this comment.
wrt adding the entire model, i think this is good for now, but we will have to make it simple to visualise interfaces etc as well. maybe we can add a specific scene object for doing this kind of detailed things...
Licini
commented
Apr 1, 2025
Licini
commented
Apr 1, 2025
Licini
commented
Apr 1, 2025
Licini
commented
Apr 1, 2025
Licini
commented
Apr 1, 2025
Licini
commented
Apr 1, 2025
Licini
commented
Apr 1, 2025
Licini
commented
Apr 1, 2025
Licini
commented
Apr 1, 2025
Licini
commented
Apr 1, 2025
Licini
commented
Apr 1, 2025
Collaborator
Author
|
@tomvanmele @petrasvestartas This is ready for review. All decisions from our last week meeting are now implemented. There is the doc build error for missing Group class from compas.datastructures which will go away once we cut a new release. |
tomvanmele
approved these changes
Apr 16, 2025
Comment on lines
+1
to
+40
| from compas.geometry import Polygon | ||
| from compas.geometry import Translation | ||
| from compas_model.elements import BeamElement | ||
| from compas_model.elements import PlateElement | ||
| from compas_model.models import Model | ||
| from compas_viewer import Viewer | ||
|
|
||
| beam1 = BeamElement(0.2, 0.3, 3) | ||
| beam2 = BeamElement(0.2, 0.3, 3) | ||
| beam3 = BeamElement(0.2, 0.3, 3) | ||
| beam4 = BeamElement(0.2, 0.3, 3) | ||
|
|
||
| beam1.transformation = Translation.from_vector([3, 3, 0]) | ||
| beam2.transformation = Translation.from_vector([-3, 3, 0]) | ||
| beam3.transformation = Translation.from_vector([-3, -3, 0]) | ||
| beam4.transformation = Translation.from_vector([3, -3, 0]) | ||
|
|
||
|
|
||
| points: list[list[float]] = [ | ||
| [-3, -3, 0], | ||
| [-3, 3, 0], | ||
| [3, 3, 0], | ||
| [3, -3, 0], | ||
| ] | ||
| polygon: Polygon = Polygon(points) | ||
| plate = PlateElement(polygon=polygon, thickness=0.2) | ||
| plate.transformation = Translation.from_vector([0, 0, 3]) | ||
|
|
||
| model = Model() | ||
| group = model.add_group(name="Beams") | ||
| model.add_element(beam1, parent=group) | ||
| model.add_element(beam2, parent=group) | ||
| model.add_element(beam3, parent=group) | ||
| model.add_element(beam4, parent=group) | ||
| model.add_element(plate) | ||
|
|
||
| # Vizualize. | ||
| viewer = Viewer() | ||
| viewer.scene.add(model) | ||
| viewer.show() |
Collaborator
There was a problem hiding this comment.
wrt adding the entire model, i think this is good for now, but we will have to make it simple to visualise interfaces etc as well. maybe we can add a specific scene object for doing this kind of detailed things...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can we take a look at this and discuss on tomorrow's dev meeting?