FIX compute_contacts with bvh and kdtree. #60
Conversation
tomvanmele
left a comment
tomvanmele
left a comment
There was a problem hiding this comment.
LGTM but see comments
| V, F = boolean_difference_mesh_mesh(A, B) | ||
| mesh: Mesh = Mesh.from_vertices_and_faces(V, F) if len(V) > 0 and len(F) > 0 else mesh0 | ||
|
|
||
| # WIP: merge coplanar mesh faces, in the future use mesh corefinement from CGAL to avoid Brep to Mesh conversion. |
There was a problem hiding this comment.
i assume you mean to avoid mesh to brep conversion
There was a problem hiding this comment.
Yes, comment is wrong.
| The minimum contact size. | ||
| k : int, optional | ||
| The number of element neighbours to consider. | ||
| search_type : str, optional |
There was a problem hiding this comment.
the correct way to document a specific set of options would be {'bvh', 'kdtree'}
There was a problem hiding this comment.
I did this a bit quick. I will redo after the workshop including the comment below.
| if search_type == "bvh": | ||
| nnbrs = self.bvh.nearest_neighbors(element) | ||
| elif search_type == "kdtree": | ||
| nnbrs_and_distances = self.element_nnbrs(element, k=k) |
There was a problem hiding this comment.
in the future, this should become something like self.kdtree.nearest_neighbors(...)
There was a problem hiding this comment.
Also distances output could be removed to avoid if statement.
nnbrs_and_distances = self.element_nnbrs(element, k=k) to nnbrs_distances = self.element_nnbrs(element, k=k)
2 participants
FIX compute_contacts with bvh and kdtree.
What type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas.datastructures.Mesh.