fix: hex_or_base64 digit recognition #40
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix a bug in the
hex_or_base64()function where digits (0-9) were not recognized as valid lowercase hex characters.Problem
The original code used
is_ascii_lowercase()to check for lowercase hex characters:However,
is_ascii_lowercase()returnsfalsefor digits0-9, causing valid lowercase hex strings like"0a1b2c3d"to be incorrectly parsed as base64 instead of hex.Solution
Use explicit pattern matching for valid lowercase hex characters (0-9, a-f):
Testing
This bug was discovered while using
hal-simplicityfor Simplicity transactions on Liquid Testnet. After the fix, hex strings containing digits are correctly parsed.