-
Notifications
You must be signed in to change notification settings - Fork 11
ENH: Add 2D cropping support and origin/spacing processing to ITK image readers #1525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joeykleingers
wants to merge
15
commits into
BlueQuartzSoftware:develop
Choose a base branch
from
joeykleingers:topic/CropImageGeometryParameter2D
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
ENH: Add 2D cropping support and origin/spacing processing to ITK image readers #1525
joeykleingers
wants to merge
15
commits into
BlueQuartzSoftware:develop
from
joeykleingers:topic/CropImageGeometryParameter2D
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joey Kleingers <joey.kleingers@bluequartz.net>
…cks. Also passed in NoCropping cropping options to Fiji Montage reader because it uses the same ITK Image Reader execute API. Still need to expose the cropping options for Fiji Montage reader as a filter parameter. Signed-off-by: Joey Kleingers <joey.kleingers@bluequartz.net>
… stack reader. This parameter determines whether the origin & spacing set by the user is set before or after reading and cropping/processing the image(s). Signed-off-by: Joey Kleingers <joey.kleingers@bluequartz.net>
Signed-off-by: Joey Kleingers <joey.kleingers@bluequartz.net>
Signed-off-by: Joey Kleingers <joey.kleingers@bluequartz.net>
Signed-off-by: Joey Kleingers <joey.kleingers@bluequartz.net>
Signed-off-by: Joey Kleingers <joey.kleingers@bluequartz.net>
Signed-off-by: Joey Kleingers <joey.kleingers@bluequartz.net>
Signed-off-by: Joey Kleingers <joey.kleingers@bluequartz.net>
Signed-off-by: Joey Kleingers <joey.kleingers@bluequartz.net>
…geometry. Signed-off-by: Joey Kleingers <joey.kleingers@bluequartz.net>
Signed-off-by: Joey Kleingers <joey.kleingers@bluequartz.net>
Signed-off-by: Joey Kleingers <joey.kleingers@bluequartz.net>
c89f751 to
8eb4111
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enhances ITK image reading filters with 2D-aware cropping capabilities and configurable origin/spacing processing timing, providing more flexible image import workflows.
Key Changes
CropGeometryParameter Enhancement
is_2dflag toCropGeometryParameterto support 2D image croppingITKImageReader & ITKImportImageStack Improvements
ReadImageUtilsto handle cropping and origin/spacing processing timingTesting
ITKImageReaderTestandITKImportImageStackTestto comprehensively test all code paths and feature interactionsTesting Performed
NOTE
This PR goes hand in hand with #1030 and should be approved and merged with it.