bug fix for Users can edit and rename shelves #5458#5514
Closed
inv-hareesh wants to merge 1 commit intoBookStackApp:developmentfrom
Closed
bug fix for Users can edit and rename shelves #5458#5514inv-hareesh wants to merge 1 commit intoBookStackApp:developmentfrom
inv-hareesh wants to merge 1 commit intoBookStackApp:developmentfrom
Conversation
Member
|
Thanks for offering @inv-hareesh but there's not really an issue to be solved here, there are already relevant permission checks on theses actions, therefore I'm going to close this off. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an issue where all users could edit and rename shelves by adding a check to ensure only admins have permission to perform these actions.