Skip to content

Enable Chromium spellchecker for webview/editor #1617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liu971227-sys wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enable Chromium spellchecker for webview/editor #1617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/components/BoostHubWebview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,9 @@ const BoostHubWebview = ({
tabIndex={-1}
useragent={boostHubWebViewUserAgent}
preload={boostHubPreloadUrl}
webpreferences='contextIsolation=no'
// Electron's webview tag uses a BrowserWindow-style feature string.
// Keep contextIsolation off (existing behavior) and enable spellcheck.
webpreferences='contextIsolation=no,spellcheck=yes'
/>
</Container>
)
Expand Down
3 changes: 3 additions & 0 deletions src/electron/windows.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ export function createAWindow(
nodeIntegration: true,
webSecurity: !dev,
webviewTag: true,
// Ensure Chromium's spellchecker is available to renderer/webviews.
// The editor still controls actual usage via `spellcheck` attributes/settings.
spellcheck: true,
enableRemoteModule: true,
contextIsolation: false,
preload: dev
Expand Down