-
Notifications
You must be signed in to change notification settings - Fork 1
MQTT update+ #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MQTT update+ #27
Conversation
tipatterson-dev
commented
Oct 8, 2025
- Add improved support for MQTT
- Clean up a few top level functions for clarity
- implement more async routines for performance
- begin codebase reorganization for planned UX improvements
- reorganization of major files
- update some URl construction methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements improved MQTT support and begins a significant codebase reorganization. It introduces a new streamable resource architecture, consolidates data models, and cleans up the module structure for planned UX improvements.
- Introduces new streamable resource system with websocket and MQTT connectivity
- Consolidates scattered data models into unified modules
- Removes numerous deprecated API helper modules and restructures imports
Reviewed Changes
Copilot reviewed 46 out of 55 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/oshconnect/streamableresource.py | New comprehensive module implementing the streamable resource architecture with Node, System, Datastream classes |
| src/oshconnect/schema_datamodels.py | Consolidated schema data models from multiple scattered modules |
| src/oshconnect/resource_datamodels.py | Unified resource data models replacing core_datamodels.py |
| tests/ | Updated test files with new import paths and test structure |
| src/oshconnect/csapi4py/ | Various updates to API helpers and MQTT client improvements |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.