Skip to content

Conversation

@tipatterson-dev
Copy link
Collaborator

  • Add improved support for MQTT
  • Clean up a few top level functions for clarity
  • implement more async routines for performance
  • begin codebase reorganization for planned UX improvements

@tipatterson-dev tipatterson-dev marked this pull request as draft October 8, 2025 05:41
@tipatterson-dev tipatterson-dev marked this pull request as ready for review October 8, 2025 05:42
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements improved MQTT support and begins a significant codebase reorganization. It introduces a new streamable resource architecture, consolidates data models, and cleans up the module structure for planned UX improvements.

  • Introduces new streamable resource system with websocket and MQTT connectivity
  • Consolidates scattered data models into unified modules
  • Removes numerous deprecated API helper modules and restructures imports

Reviewed Changes

Copilot reviewed 46 out of 55 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
src/oshconnect/streamableresource.py New comprehensive module implementing the streamable resource architecture with Node, System, Datastream classes
src/oshconnect/schema_datamodels.py Consolidated schema data models from multiple scattered modules
src/oshconnect/resource_datamodels.py Unified resource data models replacing core_datamodels.py
tests/ Updated test files with new import paths and test structure
src/oshconnect/csapi4py/ Various updates to API helpers and MQTT client improvements

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@tipatterson-dev tipatterson-dev merged commit 7bc8f16 into main Oct 8, 2025
4 checks passed
@tipatterson-dev tipatterson-dev deleted the mqtt branch October 8, 2025 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants