Skip to content

Conversation

@HMS17
Copy link
Contributor

@HMS17 HMS17 commented Dec 12, 2025

Description

Story: BI-2234 - Improve exp dataset export file

Changes to make sub entity dataset export file contain desired columns while not altering the top level export file

  • Added backend logic to distinguish between top level and sub entity datasets when exporting and change columns present accordingly
  • Updated backend to fill additional sub-entity columns with correct data
  • Updated sorting of export file in sub-entity case to also sort by Sub Unit ID (sorting of sub entity dataset UI will be in BI-2755)

Dependencies

n/a

Testing

  • Create an experiment with both a top level and sub entity dataset
  • Download top level dataset: check that file is sorted env > exp unit id, data is correct, and there are no sub-entity columns
  • Download sub entity dataset: check that file is sorted env > exp unit id > sub unit id, data is correct, and there are the following columns present
    -- Exp Unit
    -- Sub-Obs Unit
    -- Exp Unit ID
    -- Sub Unit ID
    -- (Exp Unit Level) ObsUnitID
    -- (Sub-Obs Unit Level) ObsUnitID

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@HMS17 HMS17 marked this pull request as ready for review December 12, 2025 14:11
@HMS17 HMS17 requested a review from nickpalladino December 12, 2025 14:27
@HMS17 HMS17 requested a review from nickpalladino December 15, 2025 21:06
@nickpalladino nickpalladino merged commit 05a5636 into develop Dec 15, 2025
10 checks passed
@nickpalladino nickpalladino deleted the feature/BI-2234 branch December 15, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants