Skip to content

Conversation

@HMS17
Copy link
Contributor

@HMS17 HMS17 commented Dec 16, 2025

Description

Story: BI-2755 - improve default sub-unit sort

Updated BrAPITrialService:sortDefaultForObservationUnit to conditionally sort data depending on whether the dataset is top level or sub entity, and in the case of sub-entity sort by environment > experimental unit id > sub unit id

Dependencies

bi-web: BI-2755

Testing

Create an experiment with multiple environments and a sub-entity dataset
On the top level dataset tab: ensure table is sorted by Env > Exp Unit ID
On the sub entity tab: ensure table is sorted by Env > Exp Unit ID > Sub Unit ID

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have tested that my code works with both the brapi-java-server and BreedBase
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <please include a link to TAF run>

@HMS17 HMS17 requested a review from nickpalladino December 16, 2025 14:19
@HMS17 HMS17 marked this pull request as ready for review December 16, 2025 14:20
Copy link
Member

@nickpalladino nickpalladino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When testing the only thing that was a little misleading was dataset table showing the table column sort arrow being on EnvYear when that's not really the sorting that is being shown. I'm ok moving this through but we may want to change that in a future card.

@HMS17
Copy link
Contributor Author

HMS17 commented Dec 17, 2025

When testing the only thing that was a little misleading was dataset table showing the table column sort arrow being on EnvYear when that's not really the sorting that is being shown. I'm ok moving this through but we may want to change that in a future card.

Good catch, it's a small change so added a bi-web branch to PR Breeding-Insight/bi-web#452

@nickpalladino
Copy link
Member

tested with new front-end change and looks good

@nickpalladino nickpalladino merged commit ec139fb into develop Dec 17, 2025
3 checks passed
@nickpalladino nickpalladino deleted the feature/BI-2755 branch December 17, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants