Skip to content

BI-2796 - Autocompletions for dataset names in the program including other experiments displayed but unable to select #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HMS17 merged 2 commits into from
Feb 20, 2026
Merged

BI-2796 - Autocompletions for dataset names in the program including other experiments displayed but unable to select #497

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f6f047
Fix status code check
nickpalladino Feb 19, 2026
a4906fa
Merge branch 'develop' into bug/BI-2796
HMS17 Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/main/java/org/breedinginsight/brapi/v2/services/BrAPITrialService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,9 +465,11 @@ public Dataset createSubEntityDataset(Program program, UUID experimentId, SubEnt

String programDbId = program.getBrapiProgram() != null ? program.getBrapiProgram().getProgramDbId() : null;
HttpResponse<String> levelResponse = observationLevelDAO.createObservationLevelName(program, datasetName, DatasetLevel.SUB_OBS_UNIT, programDbId);
if (levelResponse.getStatus() == HttpStatus.CONFLICT) {
throw new AlreadyExistsException("Dataset name already exists in this experiment");
} else if (levelResponse.getStatus().getCode() < 200 || levelResponse.getStatus().getCode() >= 300) {

// 409 and 200 are expected response codes, anything else error out
// 409 means level already exists so we just use the name in OUs
// 200 means level was created successfully and can use the name in OUs
if (levelResponse.getStatus() != HttpStatus.CONFLICT && levelResponse.getStatus() != HttpStatus.OK) {
throw new ApiException(levelResponse.getStatus().getCode(), "Unable to create observation level: " + levelResponse.getStatus().getReason());
}

Expand Down