-
Notifications
You must be signed in to change notification settings - Fork 1
BI-2218 Optimize sandbox landing page for mobile device #442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickpalladino
approved these changes
May 7, 2025
mlm483
requested changes
May 7, 2025
Contributor
mlm483
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few issues.
- When
VUE_APP_SANDBOX=public(public sandbox) a banner is shown on the first visit to the public sandbox, which is still present and covers the whole screen on mobile.

- When
VUE_APP_SANDBOX=true(private sandbox) orVUE_APP_SANDBOX=false(not a sandbox) the side nav is in the way and cannot be closed on mobile.
Contributor
Author
Per Shawn; the banner can stay as is.
The side nav will default to hidden in these conditions |
mlm483
approved these changes
May 28, 2025
Contributor
mlm483
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BI-2218 Optimize sandbox landing page for mobile device
Please include a summary of the change that was made.
The
LOG INbutton will stay visible in the side bar, even when viewed by a phone in landscape.Dependencies
bi-api: future/1.2
Testing
To test in you local environment set the environment variable
VUE_APP_SANDBOX= public.If testing in you browser, use the Developer Tools to view the page in responsive mode (width = 360px or less)
Go to Welcome Page.
EXPECTED RESULT
The
LOG INbutton should be visible and active.Checklist: