Skip to content

Conversation

@davedrp
Copy link
Contributor

@davedrp davedrp commented May 7, 2025

Description

BI-2218 Optimize sandbox landing page for mobile device

Please include a summary of the change that was made.
The LOG IN button will stay visible in the side bar, even when viewed by a phone in landscape.

Dependencies

bi-api: future/1.2

Testing

To test in you local environment set the environment variable VUE_APP_SANDBOX= public.
If testing in you browser, use the Developer Tools to view the page in responsive mode (width = 360px or less)
Go to Welcome Page.

EXPECTED RESULT
The LOG IN button should be visible and active.

Checklist:

  • [x ] I have performed a self-review of my own code
  • [ x] I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>
  • I have run SiteImprove on pages impacted by changes

@davedrp davedrp requested review from a team, mlm483 and nickpalladino and removed request for a team May 7, 2025 14:10
Copy link
Contributor

@mlm483 mlm483 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few issues.

  1. When VUE_APP_SANDBOX=public (public sandbox) a banner is shown on the first visit to the public sandbox, which is still present and covers the whole screen on mobile.
    Screenshot 2025-05-07 at 2 48 25 PM
  2. When VUE_APP_SANDBOX=true (private sandbox) or VUE_APP_SANDBOX=false (not a sandbox) the side nav is in the way and cannot be closed on mobile.
Screenshot 2025-05-07 at 2 43 45 PM

@davedrp davedrp force-pushed the feature/BI-2218 branch from dc54131 to f2d2249 Compare May 28, 2025 19:37
@davedrp davedrp closed this May 28, 2025
@davedrp
Copy link
Contributor Author

davedrp commented May 28, 2025

There are a few issues.

1. When `VUE_APP_SANDBOX=public` (public sandbox) a banner is shown on the first visit to the public sandbox, which is still present and covers the whole screen on mobile.

Per Shawn; the banner can stay as is.

2. When `VUE_APP_SANDBOX=true` (private sandbox) or `VUE_APP_SANDBOX=false` (not a sandbox) the side nav is in the way and cannot be closed on mobile.

The side nav will default to hidden in these conditions

@davedrp davedrp requested a review from mlm483 May 28, 2025 19:50
@mlm483 mlm483 reopened this May 28, 2025
Copy link
Contributor

@mlm483 mlm483 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@davedrp davedrp changed the base branch from future/1.2 to develop June 2, 2025 13:56
@davedrp davedrp changed the base branch from develop to future/1.2 June 2, 2025 14:40
@davedrp davedrp changed the base branch from future/1.2 to develop June 3, 2025 15:47
@davedrp davedrp merged commit eaa38e1 into develop Jun 3, 2025
1 check passed
@davedrp davedrp deleted the feature/BI-2218 branch June 3, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants