Skip to content

Conversation

@davedrp
Copy link
Contributor

@davedrp davedrp commented Jun 5, 2025

Description

BI-2218 Optimize sandbox landing page for mobile device

Please include a summary of the change that was made.

  • fixed logic in BaseSideBarLayou::mounted
    • The sidebar now is always visible when the system in NOT in sandbox mode.
  • Made code a little more readable.

Dependencies

bi-api: develop

Testing

  1. To test in you local environment set the environment variable VUE_APP_SANDBOX= "" (or don't set the environment variable at all).
  2. re-start the web server.
  3. Go to Welcome Page.
  4. refresh page

EXPECTED RESULT

The sidebar should be visible

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>
  • I have run SiteImprove on pages impacted by changes

@davedrp davedrp requested review from a team, HMS17, dmeidlin and nickpalladino and removed request for a team and dmeidlin June 5, 2025 18:45
Copy link
Contributor

@HMS17 HMS17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing locally, sidebar is hidden when expected and visible when expected!

@davedrp davedrp merged commit a4b9413 into develop Jun 12, 2025
2 checks passed
@davedrp davedrp deleted the feature/BI-2218_2 branch June 12, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants