Skip to content

Conversation

@dmeidlin
Copy link
Contributor

@dmeidlin dmeidlin commented Aug 8, 2025

Description

Story: BI-2628

The experiment append workflow import preview is showing the wrong count for phenotypic variables.

The frontend import preview template parent component passes the phenotypic dynamic columns used in the import to the experiment import preview child component. Since the dynamicColumns field in the backend preview response now includes additional dynamic columns(the ObsUnitID columns used in the append workflow), the phenotypic columns need to be selected and only these passed to the preview component.

This PR just moves the filter that was used in the experiment preview component to the parent import template component.

Dependencies

biapi:develop

Testing

  1. Download an experiment.
  2. Use the Append workflow to import observation data.
  3. Verify that import completed successfully.
  4. Verify that the import preview displays the correct number for the "Observation Variables" field.

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have create/modified unit tests to cover this change
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have run TAF: <link to TAF run>
  • I have run SiteImprove on pages impacted by changes

@dmeidlin dmeidlin requested review from a team, HMS17 and nickpalladino and removed request for a team August 8, 2025 14:02
@dmeidlin dmeidlin merged commit bc54114 into develop Aug 18, 2025
2 checks passed
@dmeidlin dmeidlin deleted the feature/BI-2628-2 branch August 18, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants