Skip to content

Fix broken angular block #1705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
armgjoka wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Fix broken angular block #1705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
35ed1dc
fix broken angular block
armgjoka Feb 27, 2025
9f16ffd
remove console.log
armgjoka Feb 27, 2025
2f62566
add changeset
armgjoka Feb 27, 2025
dce1a7f
update testing
armgjoka Mar 20, 2025
469ffa3
fix prettier
armgjoka Mar 20, 2025
9b647c6
update
armgjoka Mar 20, 2025
e6790af
last update
armgjoka Mar 20, 2025
8cac9bc
updated
armgjoka Mar 20, 2025
6565027
update
armgjoka Mar 20, 2025
c777f4d
check
armgjoka Mar 20, 2025
e166bab
update
armgjoka Mar 20, 2025
81e48f0
update, but not working
armgjoka Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tender-flies-remember.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@builder.io/mitosis': patch
---

[Angular] Update innerHtml parsing to escape quotes
90 changes: 90 additions & 0 deletions packages/core/src/__tests__/__snapshots__/angular.import.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4665,6 +4665,49 @@ export class MyComponentModule {}
"
`;

exports[`Angular with Preserve Imports and File Extensions > jsx > Javascript Test > escapeQuotesInnerHTML 1`] = `
"/**
useMetadata:
{\\"angular\\":{\\"changeDetection\\":\\"OnPush\\"}}
*/

import { NgModule } from \\"@angular/core\\";
import { CommonModule } from \\"@angular/common\\";

import { Component, ChangeDetectionStrategy } from \\"@angular/core\\";
import { DomSanitizer } from \\"@angular/platform-browser\\";

@Component({
selector: \\"my-component\\",
template: \`
<div
[innerHTML]='sanitizer.bypassSecurityTrustHtml(\\\\\`<link href=\\"https://fonts.googleapis.com/css2?family=Inter&display=swap\\" rel=\\"stylesheet\\">
<script src=\\"URL_1\\" defer></script>
<script src=\\"URL_2\\"></script>\\\\\`)'
></div>
\`,
changeDetection: ChangeDetectionStrategy.OnPush,
styles: [
\`
:host {
display: contents;
}
\`,
],
})
export default class MyComponent {
constructor(protected sanitizer) {}
}

@NgModule({
declarations: [MyComponent],
imports: [CommonModule],
exports: [MyComponent],
})
export class MyComponentModule {}
"
`;

exports[`Angular with Preserve Imports and File Extensions > jsx > Javascript Test > eventInputAndChange 1`] = `
"import { NgModule } from \\"@angular/core\\";
import { CommonModule } from \\"@angular/common\\";
Expand Down Expand Up @@ -12922,6 +12965,53 @@ export class MyComponentModule {}
"
`;

exports[`Angular with Preserve Imports and File Extensions > jsx > Typescript Test > escapeQuotesInnerHTML 1`] = `
"/**
useMetadata:
{\\"angular\\":{\\"changeDetection\\":\\"OnPush\\"}}
*/

import { NgModule } from \\"@angular/core\\";
import { CommonModule } from \\"@angular/common\\";

import { Component, ChangeDetectionStrategy } from \\"@angular/core\\";
import { DomSanitizer } from \\"@angular/platform-browser\\";

export interface MyComponentProps {
text?: string;
}

@Component({
selector: \\"my-component\\",
template: \`
<div
[innerHTML]='sanitizer.bypassSecurityTrustHtml(\\\\\`<link href=\\"https://fonts.googleapis.com/css2?family=Inter&display=swap\\" rel=\\"stylesheet\\">
<script src=\\"URL_1\\" defer></script>
<script src=\\"URL_2\\"></script>\\\\\`)'
></div>
\`,
changeDetection: ChangeDetectionStrategy.OnPush,
styles: [
\`
:host {
display: contents;
}
\`,
],
})
export default class MyComponent {
constructor(protected sanitizer: DomSanitizer) {}
}

@NgModule({
declarations: [MyComponent],
imports: [CommonModule],
exports: [MyComponent],
})
export class MyComponentModule {}
"
`;

exports[`Angular with Preserve Imports and File Extensions > jsx > Typescript Test > eventInputAndChange 1`] = `
"import { NgModule } from \\"@angular/core\\";
import { CommonModule } from \\"@angular/common\\";
Expand Down
92 changes: 92 additions & 0 deletions packages/core/src/__tests__/__snapshots__/angular.mapper.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4735,6 +4735,50 @@ export class MyComponentModule {}
"
`;

exports[`Angular with Import Mapper Tests > jsx > Javascript Test > escapeQuotesInnerHTML 1`] = `
"/**
useMetadata:
{\\"angular\\":{\\"changeDetection\\":\\"OnPush\\"}}
*/

import { NgModule } from \\"@angular/core\\";
import { CommonModule } from \\"@angular/common\\";

import { Component, ChangeDetectionStrategy } from \\"@angular/core\\";
import { DomSanitizer } from \\"@angular/platform-browser\\";

@Component({
selector: \\"my-component\\",
template: \`
<div
[innerHTML]='sanitizer.bypassSecurityTrustHtml(\\\\\`<link href=\\"https://fonts.googleapis.com/css2?family=Inter&display=swap\\" rel=\\"stylesheet\\">
<script src=\\"URL_1\\" defer></script>
<script src=\\"URL_2\\"></script>\\\\\`)'
></div>
\`,
changeDetection: ChangeDetectionStrategy.OnPush,
styles: [
\`
:host {
display: contents;
}
\`,
],
})
export default class MyComponent {
constructor(protected sanitizer) {}
}

@NgModule({
declarations: [MyComponent],
imports: [CommonModule],
exports: [MyComponent],
bootstrap: [SomeOtherComponent],
})
export class MyComponentModule {}
"
`;

exports[`Angular with Import Mapper Tests > jsx > Javascript Test > eventInputAndChange 1`] = `
"import { NgModule } from \\"@angular/core\\";
import { CommonModule } from \\"@angular/common\\";
Expand Down Expand Up @@ -13127,6 +13171,54 @@ export class MyComponentModule {}
"
`;

exports[`Angular with Import Mapper Tests > jsx > Typescript Test > escapeQuotesInnerHTML 1`] = `
"/**
useMetadata:
{\\"angular\\":{\\"changeDetection\\":\\"OnPush\\"}}
*/

import { NgModule } from \\"@angular/core\\";
import { CommonModule } from \\"@angular/common\\";

import { Component, ChangeDetectionStrategy } from \\"@angular/core\\";
import { DomSanitizer } from \\"@angular/platform-browser\\";

export interface MyComponentProps {
text?: string;
}

@Component({
selector: \\"my-component\\",
template: \`
<div
[innerHTML]='sanitizer.bypassSecurityTrustHtml(\\\\\`<link href=\\"https://fonts.googleapis.com/css2?family=Inter&display=swap\\" rel=\\"stylesheet\\">
<script src=\\"URL_1\\" defer></script>
<script src=\\"URL_2\\"></script>\\\\\`)'
></div>
\`,
changeDetection: ChangeDetectionStrategy.OnPush,
styles: [
\`
:host {
display: contents;
}
\`,
],
})
export default class MyComponent {
constructor(protected sanitizer: DomSanitizer) {}
}

@NgModule({
declarations: [MyComponent],
imports: [CommonModule],
exports: [MyComponent],
bootstrap: [SomeOtherComponent],
})
export class MyComponentModule {}
"
`;

exports[`Angular with Import Mapper Tests > jsx > Typescript Test > eventInputAndChange 1`] = `
"import { NgModule } from \\"@angular/core\\";
import { CommonModule } from \\"@angular/common\\";
Expand Down
90 changes: 90 additions & 0 deletions packages/core/src/__tests__/__snapshots__/angular.state.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4847,6 +4847,49 @@ export class MyComponentModule {}
"
`;

exports[`Angular with manually creating and handling class properties as bindings (more stable) > jsx > Javascript Test > escapeQuotesInnerHTML 1`] = `
"/**
useMetadata:
{\\"angular\\":{\\"changeDetection\\":\\"OnPush\\"}}
*/

import { NgModule } from \\"@angular/core\\";
import { CommonModule } from \\"@angular/common\\";

import { Component, ChangeDetectionStrategy } from \\"@angular/core\\";
import { DomSanitizer } from \\"@angular/platform-browser\\";

@Component({
selector: \\"my-component\\",
template: \`
<div
[innerHTML]='sanitizer.bypassSecurityTrustHtml(\\\\\`<link href=\\"https://fonts.googleapis.com/css2?family=Inter&display=swap\\" rel=\\"stylesheet\\">
<script src=\\"URL_1\\" defer></script>
<script src=\\"URL_2\\"></script>\\\\\`)'
></div>
\`,
changeDetection: ChangeDetectionStrategy.OnPush,
styles: [
\`
:host {
display: contents;
}
\`,
],
})
export default class MyComponent {
constructor(protected sanitizer) {}
}

@NgModule({
declarations: [MyComponent],
imports: [CommonModule],
exports: [MyComponent],
})
export class MyComponentModule {}
"
`;

exports[`Angular with manually creating and handling class properties as bindings (more stable) > jsx > Javascript Test > eventInputAndChange 1`] = `
"import { NgModule } from \\"@angular/core\\";
import { CommonModule } from \\"@angular/common\\";
Expand Down Expand Up @@ -13433,6 +13476,53 @@ export class MyComponentModule {}
"
`;

exports[`Angular with manually creating and handling class properties as bindings (more stable) > jsx > Typescript Test > escapeQuotesInnerHTML 1`] = `
"/**
useMetadata:
{\\"angular\\":{\\"changeDetection\\":\\"OnPush\\"}}
*/

import { NgModule } from \\"@angular/core\\";
import { CommonModule } from \\"@angular/common\\";

import { Component, ChangeDetectionStrategy } from \\"@angular/core\\";
import { DomSanitizer } from \\"@angular/platform-browser\\";

export interface MyComponentProps {
text?: string;
}

@Component({
selector: \\"my-component\\",
template: \`
<div
[innerHTML]='sanitizer.bypassSecurityTrustHtml(\\\\\`<link href=\\"https://fonts.googleapis.com/css2?family=Inter&display=swap\\" rel=\\"stylesheet\\">
<script src=\\"URL_1\\" defer></script>
<script src=\\"URL_2\\"></script>\\\\\`)'
></div>
\`,
changeDetection: ChangeDetectionStrategy.OnPush,
styles: [
\`
:host {
display: contents;
}
\`,
],
})
export default class MyComponent {
constructor(protected sanitizer: DomSanitizer) {}
}

@NgModule({
declarations: [MyComponent],
imports: [CommonModule],
exports: [MyComponent],
})
export class MyComponentModule {}
"
`;

exports[`Angular with manually creating and handling class properties as bindings (more stable) > jsx > Typescript Test > eventInputAndChange 1`] = `
"import { NgModule } from \\"@angular/core\\";
import { CommonModule } from \\"@angular/common\\";
Expand Down
Loading